All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	Bill Pemberton <wfp5p@virginia.edu>,
	Arnaud Patard <apatard@mandriva.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: xgifb: Removes unnecessary log
Date: Mon, 6 Sep 2010 23:14:20 -0700	[thread overview]
Message-ID: <20100907061420.GA2889@kroah.com> (raw)
In-Reply-To: <1283837309.6302.4.camel@lenovo>

On Tue, Sep 07, 2010 at 01:28:29AM -0400, Javier Martinez Canillas wrote:
> This patch fixes a compile warning in today linux-next.

Note, you need to fix up how your patches are generated.  [1/1] and then
[2/2] and then [3/3] would cause me to belive that I'm missing some
patches you would have sent out (1/2, 1/3, and 2/3).  Just use git
format-patch to generate them if you have a problem with them.

> The first version of this patch casted XGIFB_GET_INFO to unsigned long, but Greg suggest that I should use %p instead and that the whole message is just looney.

Please wrap your lines at 72 characters.

thanks,

greg k-h

  reply	other threads:[~2010-09-07  6:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07  5:28 [PATCH 1/1] staging: xgifb: Removes unnecessary log Javier Martinez Canillas
2010-09-07  6:14 ` Greg KH [this message]
2010-09-07  6:16 ` Greg KH
2010-09-07 12:43   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100907061420.GA2889@kroah.com \
    --to=greg@kroah.com \
    --cc=apatard@mandriva.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    --cc=randy.dunlap@oracle.com \
    --cc=wfp5p@virginia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.