diff for duplicates of <20100907213818.GA5351@bicker> diff --git a/a/1.txt b/N1/1.txt index e922bde..fd21be9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,12 @@ On Tue, Sep 07, 2010 at 06:38:05AM -0700, mark gross wrote: > > spin_unlock_irqrestore(&pm_qos_lock, flags); > > @@ -374,10 +374,12 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf, -> > } else if (count = 11) { /* len('0x12345678/0') */ +> > } else if (count == 11) { /* len('0x12345678/0') */ > > if (copy_from_user(ascii_value, buf, 11)) > > return -EFAULT; > > + if (strlen(ascii_value) > 10) -> should be !> +> should be != +> > > + return -EINVAL; > > x = sscanf(ascii_value, "%x", &value); > > if (x != 1) diff --git a/a/content_digest b/N1/content_digest index 9413d56..7b09544 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020100907133805.GA20050@gvim.org\0" "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [patch] pm_qos_params: cleanup: terminate a string\0" - "Date\0Tue, 07 Sep 2010 21:38:18 +0000\0" + "Date\0Tue, 7 Sep 2010 23:38:18 +0200\0" "To\0mark gross <markgross@thegnar.org>\0" "Cc\0Rafael J. Wysocki <rjw@sisk.pl>" James Bottomley <James.Bottomley@suse.de> @@ -16,11 +16,12 @@ "On Tue, Sep 07, 2010 at 06:38:05AM -0700, mark gross wrote:\n" "> > \tspin_unlock_irqrestore(&pm_qos_lock, flags);\n" "> > @@ -374,10 +374,12 @@ static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf,\n" - "> > \t} else if (count = 11) { /* len('0x12345678/0') */\n" + "> > \t} else if (count == 11) { /* len('0x12345678/0') */\n" "> > \t\tif (copy_from_user(ascii_value, buf, 11))\n" "> > \t\t\treturn -EFAULT;\n" "> > +\t\tif (strlen(ascii_value) > 10)\n" - "> should be !> \n" + "> should be !=\n" + "> \n" "> > +\t\t\treturn -EINVAL;\n" "> > \t\tx = sscanf(ascii_value, \"%x\", &value);\n" "> > \t\tif (x != 1)\n" @@ -37,4 +38,4 @@ "regards,\n" dan carpenter -c0f8a5bc9a5bdcf2c1bdb648aebdd7564592b6dd39b1d61b01b1b427d054f708 +2fb2c1c00e72cf6a455ca7cf6977257d099e4aa4e6dc2655a788581343effb08
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.