From: Andi Kleen <andi@firstfloor.org>
To: Paul Moore <paul.moore@hp.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
x86@kernel.org, Al Viro <viro@ZenIV.linux.org.uk>,
arjan@infradead.org, davem@davemloft.net
Subject: Re: [PATCH] Remove implicit list prefetches for most cases
Date: Wed, 8 Sep 2010 15:45:14 +0200 [thread overview]
Message-ID: <20100908154514.7c8596ae@basil.nowhere.org> (raw)
In-Reply-To: <1283949179.4480.3.camel@flek>
>
> If prefetch() is generally considered a "Bad Thing",
Using it unconditionally in list_for_each style operations at least is.
>
I'm OK with just
> removing them from NetLabel; no need to rename and conditionalize. I
> put them in the netlbl_af[4,6]list_*() routines because those routines
> were modeled after the normal list routines which had prefetches and I
> just assumed someone much smarter had found them to be a win.
Unless you have gigantic list walk bodies they are unlikely to be
on anything modern.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-09-08 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 8:59 [PATCH] Remove implicit list prefetches for most cases Andi Kleen
2010-09-08 12:32 ` Paul Moore
2010-09-08 13:45 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100908154514.7c8596ae@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.