From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarek Poplawski Subject: Re: [PATCH net-next-2.6] net: inet_add_protocol() can use cmpxchg() Date: Thu, 9 Sep 2010 07:09:26 +0000 Message-ID: <20100909070926.GB6951@ff.dom.local> References: <20100909064222.GA6951@ff.dom.local> <1284015345.2428.37.camel@edumazet-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , jesse@nicira.com, netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:48799 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031Ab0IIHJc (ORCPT ); Thu, 9 Sep 2010 03:09:32 -0400 Received: by bwz11 with SMTP id 11so862271bwz.19 for ; Thu, 09 Sep 2010 00:09:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1284015345.2428.37.camel@edumazet-laptop> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 09, 2010 at 08:55:45AM +0200, Eric Dumazet wrote: > Le jeudi 09 septembre 2010 ?? 06:42 +0000, Jarek Poplawski a =E9crit = : > > Of course, each case is different, but generally I understand Jesse= 's > > concern. Smaller data section argument shouldn't be enough. There i= s > > some reason we do it in C not asm, and there is some cost of > > unreadable code too. >=20 > Sure, but is cmpxchg() really not readable for you ? ;) Just like for Jesse: "this takes a little more thought". ;-) Jarek P.