From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anton Vorontsov Subject: Re: [PATCH 0/8] sdhci: Move real work out of an atomic context Date: Thu, 9 Sep 2010 11:15:07 +0400 Message-ID: <20100909071507.GA14308@oksana.dev.rtsoft.ru> References: <20100714130728.GA27339@oksana.dev.rtsoft.ru> <20100907153813.936db0c6.akpm@linux-foundation.org> <20100908213740.GA7550@void.printf.net> <20100909022834.GA10542@void.printf.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:43290 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751269Ab0IIHPN (ORCPT ); Thu, 9 Sep 2010 03:15:13 -0400 Content-Disposition: inline In-Reply-To: <20100909022834.GA10542@void.printf.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: Andrew Morton , Wolfram Sang , Albert Herranz , Matt Fleming , Ben Dooks , Pierre Ossman , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org On Thu, Sep 09, 2010 at 03:28:34AM +0100, Chris Ball wrote: [...] > [ 7.372843] [] __might_sleep+0xd9/0xe0 > [ 7.387864] [] mutex_lock+0x1c/0x2a > [ 7.402576] [] sdhci_led_control+0x1a/0x41 > [ 7.417727] [] led_trigger_event+0x42/0x5c led_trigger_even grabs a readlock. :-( > [ 7.432807] [] mmc_request_done+0x56/0x6f > [ 7.447597] [] sdhci_finish_work+0xc8/0xcd > [ 7.462643] [] ? sdhci_finish_work+0x0/0xcd > [ 7.477941] [] worker_thread+0x165/0x1ed > [ 7.492856] [] ? sdhci_finish_work+0x0/0xcd > [ 7.508204] [] ? autoremove_wake_function+0x0/0x34 > [ 7.524178] [] ? worker_thread+0x0/0x1ed > [ 7.538953] [] kthread+0x63/0x68 > [ 7.552659] [] ? kthread+0x0/0x68 > [ 7.566349] [] kernel_thread_helper+0x6/0x10 > [ 7.709931] udev: starting version 141 > [ 7.940374] mmc2: new high speed SDHC card at address e4da > [ 8.058165] mmcblk0: mmc2:e4da SU04G 3.69 GiB > [ 8.135730] mmcblk0: p1 p2 > > Full dmesg is at http://chris.printf.net/anton-mutex-dmesg.txt. > Anton, the kernel is 2.6.35.4-olpc plus your patchset from -mm. > I can think about how to test on an upstream kernel instead, but > perhaps your own tests simply didn't hit sdhci_led_control(). Yep, LEDS support was turned off. > Andrew, if you want to drop this while the BUG() and potential > performance regressions are worked out, I'd be happy to keep > testing patches from Anton until it's without regressions here. Thanks Chris. I also think that it's better to drop these series now, and meanwhile I'll try to prepare another patchset. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ew0-f42.google.com (mail-ew0-f42.google.com [209.85.215.42]) by ozlabs.org (Postfix) with ESMTP id 6C870B6F01 for ; Thu, 9 Sep 2010 17:15:14 +1000 (EST) Received: by ewy2 with SMTP id 2so738063ewy.15 for ; Thu, 09 Sep 2010 00:15:12 -0700 (PDT) Date: Thu, 9 Sep 2010 11:15:07 +0400 From: Anton Vorontsov To: Chris Ball Subject: Re: [PATCH 0/8] sdhci: Move real work out of an atomic context Message-ID: <20100909071507.GA14308@oksana.dev.rtsoft.ru> References: <20100714130728.GA27339@oksana.dev.rtsoft.ru> <20100907153813.936db0c6.akpm@linux-foundation.org> <20100908213740.GA7550@void.printf.net> <20100909022834.GA10542@void.printf.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <20100909022834.GA10542@void.printf.net> Cc: Matt Fleming , Albert Herranz , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Ben Dooks , Andrew Morton , Pierre Ossman List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Sep 09, 2010 at 03:28:34AM +0100, Chris Ball wrote: [...] > [ 7.372843] [] __might_sleep+0xd9/0xe0 > [ 7.387864] [] mutex_lock+0x1c/0x2a > [ 7.402576] [] sdhci_led_control+0x1a/0x41 > [ 7.417727] [] led_trigger_event+0x42/0x5c led_trigger_even grabs a readlock. :-( > [ 7.432807] [] mmc_request_done+0x56/0x6f > [ 7.447597] [] sdhci_finish_work+0xc8/0xcd > [ 7.462643] [] ? sdhci_finish_work+0x0/0xcd > [ 7.477941] [] worker_thread+0x165/0x1ed > [ 7.492856] [] ? sdhci_finish_work+0x0/0xcd > [ 7.508204] [] ? autoremove_wake_function+0x0/0x34 > [ 7.524178] [] ? worker_thread+0x0/0x1ed > [ 7.538953] [] kthread+0x63/0x68 > [ 7.552659] [] ? kthread+0x0/0x68 > [ 7.566349] [] kernel_thread_helper+0x6/0x10 > [ 7.709931] udev: starting version 141 > [ 7.940374] mmc2: new high speed SDHC card at address e4da > [ 8.058165] mmcblk0: mmc2:e4da SU04G 3.69 GiB > [ 8.135730] mmcblk0: p1 p2 > > Full dmesg is at http://chris.printf.net/anton-mutex-dmesg.txt. > Anton, the kernel is 2.6.35.4-olpc plus your patchset from -mm. > I can think about how to test on an upstream kernel instead, but > perhaps your own tests simply didn't hit sdhci_led_control(). Yep, LEDS support was turned off. > Andrew, if you want to drop this while the BUG() and potential > performance regressions are worked out, I'd be happy to keep > testing patches from Anton until it's without regressions here. Thanks Chris. I also think that it's better to drop these series now, and meanwhile I'll try to prepare another patchset. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2