diff for duplicates of <20100910034603.GA2612@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index b718da0..b27a70e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,7 +7,7 @@ On Thu, Sep 09, 2010 at 05:14:43PM +0200, Arnd Bergmann wrote: > > > > typeof(*p) *_________p1 = (typeof(*p)*__force )ACCESS_ONCE(p); \ > > > > ^ > > > > rcu_lockdep_assert(c); \ -> > > > (void) (((typeof (*p) space *)p) = p); \ +> > > > (void) (((typeof (*p) space *)p) == p); \ > > > > ^ ^ > > > > smp_read_barrier_depends(); \ > > > > ((typeof(*p) __force __kernel *)(_________p1)); \ @@ -29,7 +29,7 @@ On Thu, Sep 09, 2010 at 05:14:43PM +0200, Arnd Bergmann wrote: Hmmm... One approach would be have a secondary macro that was: #define __rcu_dereference_check_sparse(p, space) \ - (void) (((typeof (*p) space *)p) = p); + (void) (((typeof (*p) space *)p) == p); when running sparse and: diff --git a/a/content_digest b/N1/content_digest index 9a33701..badc4ac 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\0201009091714.44013.arnd@arndb.de\0" "From\0Paul E. McKenney <paulmck@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH] md: do not use ++ in rcu_dereference() argument\0" - "Date\0Fri, 10 Sep 2010 03:46:03 +0000\0" + "Date\0Thu, 9 Sep 2010 20:46:03 -0700\0" "To\0Arnd Bergmann <arnd@arndb.de>\0" "Cc\0Kulikov Vasiliy <segooon@gmail.com>" kernel-janitors@vger.kernel.org @@ -23,7 +23,7 @@ "> > > > typeof(*p) *_________p1 = (typeof(*p)*__force )ACCESS_ONCE(p); \\\n" "> > > > ^\n" "> > > > rcu_lockdep_assert(c); \\\n" - "> > > > (void) (((typeof (*p) space *)p) = p); \\\n" + "> > > > (void) (((typeof (*p) space *)p) == p); \\\n" "> > > > ^ ^\n" "> > > > smp_read_barrier_depends(); \\\n" "> > > > ((typeof(*p) __force __kernel *)(_________p1)); \\\n" @@ -45,7 +45,7 @@ "Hmmm... One approach would be have a secondary macro that was:\n" "\n" "\t#define __rcu_dereference_check_sparse(p, space) \\\n" - "\t\t(void) (((typeof (*p) space *)p) = p);\n" + "\t\t(void) (((typeof (*p) space *)p) == p);\n" "\n" "when running sparse and:\n" "\n" @@ -57,4 +57,4 @@ "\n" "\t\t\t\t\t\t\tThanx, Paul" -24426b803ab2210cf0eef2d6c3c6c86a3a2d2916ada6634709adeb167d1cd30e +faf5f289b150af168b0925c74c3d19b2ceac5ac0906391f9d454ae40ad01d84d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.