From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.ml.walleij@gmail.com>
Cc: Masayuki Ohtake <masa-korg@dsn.okisemi.com>,
meego-dev@meego.com, LKML <linux-kernel@vger.kernel.org>,
David Brownell <dbrownell@users.sourceforge.net>,
qi.wang@intel.com, yong.y.wang@intel.com,
andrew.chih.howe.khor@intel.com, arjan@linux.intel.com,
gregkh@suse.de, Tomoya MORINAGA <morinaga526@dsn.okisemi.com>,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35
Date: Thu, 9 Sep 2010 22:55:58 -0600 [thread overview]
Message-ID: <20100910045558.GA8436@angua.secretlab.ca> (raw)
In-Reply-To: <AANLkTimTumguZ7Tm1-zGb=D+0gghsA-b-RyhRDTQieFR@mail.gmail.com>
On Thu, Sep 09, 2010 at 10:58:38PM +0200, Linus Walleij wrote:
> 2010/9/3 Masayuki Ohtake <masa-korg@dsn.okisemi.com>:
>
> > Each instance of our SPI device has the same vendor ID and device ID.
> > Thus, I think it is impossible to be called probe() for each instance.
>
> Looking at you latest patch it appears you could :-)
> That solves the problem pretty nicely.
Actually, it doesn't look like he did. It looks to me that the
ability to support multiple spi bus instances on a single PCI device
has simply been removed. I don't know if that is because it simply
isn't needed yet, or if it is because Ohtake-san doesn't quite
understand what were suggesting.
Regardless it doesn't matter. When or if the driver does need to be
modified to support multiple instances, it is a relatively straight
forward matter to refactor the current code into a platform_driver,
and create a new pci_driver that simply registers the matching
platform_device for each spi bus instance supported by the device.
g.
next prev parent reply other threads:[~2010-09-10 4:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 5:50 [MeeGo-Dev][PATCH] Topcliff: Update PCH_SPI driver to 2.6.35 Masayuki Ohtake
2010-09-09 20:58 ` Linus Walleij
2010-09-10 0:27 ` Masayuki Ohtake
2010-09-10 1:30 ` Joe Perches
2010-09-10 1:41 ` Grant Likely
2010-09-10 2:05 ` Grant Likely
2010-09-10 4:55 ` Grant Likely [this message]
2010-09-14 2:52 ` Tomoya MORINAGA
2010-09-14 2:56 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2010-09-06 11:09 Masayuki Ohtak
2010-09-10 6:03 ` Grant Likely
2010-09-15 1:29 ` Masayuki Ohtake
2010-09-06 11:09 Masayuki Ohtak
[not found] <4C80E2D5.1020104@dsn.okisemi.com>
2010-09-03 14:46 ` Grant Likely
2010-09-03 17:50 ` Linus Walleij
2010-09-03 17:57 ` Grant Likely
2010-09-06 6:19 ` Masayuki Ohtake
2010-09-08 19:40 ` Grant Likely
[not found] <4C77BD91.9070302@dsn.okisemi.com>
2010-08-27 18:33 ` Grant Likely
2010-08-27 18:53 ` Thomas Gleixner
2010-08-27 18:54 ` Arjan van de Ven
2010-08-27 19:06 ` Thomas Gleixner
2010-08-27 19:20 ` Grant Likely
2010-08-30 7:28 ` Masayuki Ohtake
2010-08-30 12:44 ` Thomas Gleixner
2010-08-31 1:05 ` Masayuki Ohtake
2010-08-31 5:51 ` Grant Likely
2010-08-31 6:24 ` Masayuki Ohtake
2010-08-30 18:23 ` Grant Likely
2010-08-31 1:45 ` Masayuki Ohtake
2010-08-31 6:03 ` Grant Likely
2010-08-31 6:47 ` Masayuki Ohtake
2010-08-31 6:53 ` Grant Likely
2010-08-31 6:57 ` Masayuki Ohtake
2010-08-31 12:09 ` Masayuki Ohtake
[not found] <4C6131C2.4080101@dsn.okisemi.com>
2010-08-10 17:10 ` Greg KH
2010-08-11 1:25 ` Wang, Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910045558.GA8436@angua.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=andrew.chih.howe.khor@intel.com \
--cc=arjan@linux.intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=gregkh@suse.de \
--cc=linus.ml.walleij@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masa-korg@dsn.okisemi.com \
--cc=meego-dev@meego.com \
--cc=morinaga526@dsn.okisemi.com \
--cc=qi.wang@intel.com \
--cc=tglx@linutronix.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.