From: Don Zickus <dzickus@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com, robert.richter@amd.com
Subject: Re: [PATCH] perf_events: fix BTS interrupt handling to avoid being dazed by NMI (v2)
Date: Fri, 10 Sep 2010 09:25:28 -0400 [thread overview]
Message-ID: <20100910132528.GA4879@redhat.com> (raw)
In-Reply-To: <4c8a1686.aae9d80a.5aa4.5e35@mx.google.com>
On Fri, Sep 10, 2010 at 01:28:01PM +0200, Stephane Eranian wrote:
> Fix a bug introduced with commit de725de and the change in the meaning of the
> return value of intel_pmu_handle_irq(). With the current code, when you are
> using the BTS, you get 'dazed by NMI' each time the BTS buffer fills up.
>
> BTS does interrupt on the PMU vector, thus NMI. You need to take this
> into account in the return value of the function.
>
> This version fixes initial patch which was missing changes to
> perf_event_intel_ds.c.
Great work!
So does this mean my other patch that ack'd the intel pmu earlier than
before is unnecessary now? Or was this patch solving a different problem?
Cheers,
Don
next prev parent reply other threads:[~2010-09-10 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 11:28 [PATCH] perf_events: fix BTS interrupt handling to avoid being dazed by NMI (v2) Stephane Eranian
2010-09-10 13:25 ` Don Zickus [this message]
2010-09-13 8:33 ` [tip:perf/core] perf_events: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910132528.GA4879@redhat.com \
--to=dzickus@redhat.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.