From: Chris Ball <cjb@laptop.org>
To: Adrian Hunter <adrian.hunter@nokia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: mmc_test: fix performance tests that go over max_blk_count
Date: Fri, 10 Sep 2010 16:29:04 +0100 [thread overview]
Message-ID: <20100910152904.GA31914@void.printf.net> (raw)
In-Reply-To: <4C89ED69.8000301@nokia.com>
Hi Adrian,
On Fri, Sep 10, 2010 at 11:33:45AM +0300, Adrian Hunter wrote:
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -56,7 +56,9 @@ struct mmc_test_mem {
> * struct mmc_test_area - information for performance tests.
> * @max_sz: test area size (in bytes)
> * @dev_addr: address on card at which to do performance tests
> - * @max_segs: maximum segments in scatterlist @sg
> + * @max_tfr: maximum transfer size allowed by driver (in bytes)
> + * @max_segs: maximum segments allowed by driver in scatterlist @sg
> + * @max_seg_sz: maximum segment size allowed by driver
> * @blocks: number of (512 byte) blocks currently mapped by @sg
> * @sg_len: length of currently mapped scatterlist @sg
> * @mem: allocated memory
> @@ -65,7 +67,9 @@ struct mmc_test_mem {
> struct mmc_test_area {
> unsigned long max_sz;
> unsigned int dev_addr;
> + unsigned int max_tfr;
> unsigned int max_segs;
> + unsigned int max_seg_sz;
> unsigned int blocks;
> unsigned int sg_len;
> struct mmc_test_mem *mem;
This patch is corrupt, I think due to missing leading spaces on context
lines; it's suspicious that the first hunk doesn't line up properly.
Could you check and resend?
Thanks,
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2010-09-10 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 8:33 mmc_test: fix performance tests that go over max_blk_count Adrian Hunter
2010-09-10 15:29 ` Chris Ball [this message]
2010-09-10 18:58 ` Adrian Hunter
2010-09-10 20:06 ` Chris Ball
2010-09-10 20:39 ` Chris Ball
2010-09-11 23:47 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910152904.GA31914@void.printf.net \
--to=cjb@laptop.org \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.