From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mattias WALLIN <mattias.wallin@stericsson.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: SV: SV: [PATCH 2/3] MFD: AB8500 debugfs
Date: Fri, 10 Sep 2010 19:41:58 +0100 [thread overview]
Message-ID: <20100910184158.GA12787@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <33A307AF30D7BF4F811B1568FE7A9B181C357DCE@EXDCVYMBSTM006.EQ1STM.local>
On Fri, Sep 10, 2010 at 08:27:38PM +0200, Mattias WALLIN wrote:
Please fix your mail client to word wrap within paragraphs.
> >Pretty much; probably needs to be slightly more involved than that to
> >make sure the selection lines up with the core but certainly the same
> >effect for users.
> Sorry I don't follow.
If CONFIG_DEBUG_FS=y but the chip core is built as a module your
suggested change would try to build the debugfs code into the kernel
linking against symbols defined in the module.
> But after thinking about it I realize that only changing the Makefile
> is not a good idea
> I need ifdefs in the .c file for avoiding build problems. Isn't the
> first solution with Kconfig better?
I don't see what relevance of these two points to each other? You can
check for CONFIG_DEBUG_FS just as easily as for the new Kconfig symbol
you added. No matter what you do you need ifdefs in the code.
prev parent reply other threads:[~2010-09-10 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 15:53 [PATCH 2/3] MFD: AB8500 debugfs Mattias Wallin
2010-09-10 16:43 ` Mark Brown
2010-09-10 18:11 ` SV: " Mattias WALLIN
2010-09-10 18:13 ` Mark Brown
2010-09-10 18:27 ` SV: " Mattias WALLIN
2010-09-10 18:41 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910184158.GA12787@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mattias.wallin@stericsson.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.