Re: [PATCH v2] mmc: USB SD Host Controller (USHC) driver

[Chris Ball <cjb@laptop.org>]

Hi David,

On Thu, Sep 02, 2010 at 02:15:08PM +0000, David Vrabel wrote:
> Add a driver for USB SD Host Controller devices.  These devices are
> Cypress Astoria chips with firmware compliant with issue 2 of CSR's USHC
> specification.
> 
> Signed-off-by: David Vrabel <david.vrabel@csr.com>
> ---
> Changes since v1:
> - Clarified Kconfig help text.
> - mmc->f_min is 400 kHz.
> 
> Andrew, please queue for 2.6.37.

Thanks, applied to mmc-next with the following change as per
"mmc: Remove distinction between hw and phys segments".
Would you like to submit a MAINTAINERS entry for this driver?

diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index 2d0cc2c..b4ead4a 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -456,8 +456,7 @@ static int ushc_probe(struct usb_interface *intf, const struct usb_device_id *id
 	mmc->caps |= (ushc->caps & USHC_GET_CAPS_HIGH_SPD) ? MMC_CAP_SD_HIGHSPEED : 0;
 
 	mmc->max_seg_size  = 512*511;
-	mmc->max_hw_segs   = 1;
-	mmc->max_phys_segs = 1;
+	mmc->max_segs      = 1;
 	mmc->max_req_size  = 512*511;
 	mmc->max_blk_size  = 512;
 	mmc->max_blk_count = 511;

-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child