From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vms173005pub.verizon.net ([206.46.173.5]) by linuxtogo.org with esmtp (Exim 4.69) (envelope-from ) id 1OuARs-0004Bk-QV for openembedded-devel@lists.openembedded.org; Fri, 10 Sep 2010 22:43:53 +0200 Received: from gandalf.denix.org ([unknown] [71.251.53.61]) by vms173005.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0L8J0073ZTJVE92D@vms173005.mailsrvcs.net> for openembedded-devel@lists.openembedded.org; Fri, 10 Sep 2010 15:43:08 -0500 (CDT) Received: by gandalf.denix.org (Postfix, from userid 1000) id 7390D14AF64; Fri, 10 Sep 2010 16:43:07 -0400 (EDT) Date: Fri, 10 Sep 2010 16:43:07 -0400 From: Denys Dmytriyenko To: openembedded-devel@lists.openembedded.org Message-id: <20100910204307.GP28148@denix.org> References: <20100903111210.GA17702@game.jcrosoft.org> <1283570085-11968-1-git-send-email-plagnioj@jcrosoft.com> <131E5DFBE7373E4C8D813795A6AA7F080310BFA4A2@dlee06.ent.ti.com> <20100910185711.GG28148@denix.org> <4C8A95E7.7070403@mentor.com> MIME-version: 1.0 In-reply-to: <4C8A95E7.7070403@mentor.com> User-Agent: Mutt/1.5.16 (2007-06-09) X-SA-Exim-Connect-IP: 206.46.173.5 X-SA-Exim-Mail-From: denis@denix.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on discovery X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-SA-Exim-Version: 4.2.1 (built Wed, 25 Jun 2008 17:20:07 +0000) X-SA-Exim-Scanned: Yes (on linuxtogo.org) Subject: Re: [PATCH] rename SOC_FAMILY to TARGET_SOC_FAMILY and make it global X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2010 20:43:53 -0000 Content-type: text/plain; charset=us-ascii Content-disposition: inline On Fri, Sep 10, 2010 at 01:32:39PM -0700, Tom Rini wrote: > Denys Dmytriyenko wrote: >> On Wed, Sep 08, 2010 at 07:58:39AM +0200, Frans Meulenbroeks wrote: >>> 2010/9/7 Maupin, Chase : >>> >>>>> Forgot about this, but a variable should go with documentation. >>>>> This already has been raised with the orginal patch, but was ignored >>>>> by the submitters. >>>> Frans, Are you counting me as one of the original submitters? I mainly >>>> use the SOC_FAMILY, I didn't create it. That being said, if you have a >>>> recommended section of the usermanual that this should be documented in >>>> I'll try to add something. >>> Hi Chase, >>> I see you indeed as the submitter. The commit carries your name and >>> there is no reference in the commit message of another author. >>> >>> Wrt the manual: actually I thought we had a section for this, but as >>> it stands i cannot find it. Guess I saw it somewhere else. >>> I'm not really sure where it would fit. I guess there are others who >>> have a better view on the manual and its structure. >> Frans, >> I guess then you haven't read the original discussion closely enough. >> Chase only made a change to add existing SOC_FAMILY override into >> COMPATIBLE_MACHINE variable... I keep repeating myself - SOC_FAMILY >> feature is about a year old. It was introduced as part of a large merge >> from Arago. Here is the original commit and some description: >> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=b788499815bfc1974d4277c0a261b9a7c24aa816 > > I suppose you could save Chase some time, Denys, and update the manual > instead :) But to me, it's perfectly reasonable for Frans to ask that when > someone renames a not previously documented variable to go ahead and > document it too (since they must have some knowledge of how it works, and > some correct knowledge being written down is better than none). Thanks, Tom! Yes, pushing Chase's patch for documentation update is on my TODO list for later today - I'm giving people last chance to comment... I agree, updating documentation is very desirable, no objections here. I was merely commenting on Frans' note here, giving some background: >>> Hi Chase, >>> I see you indeed as the submitter. The commit carries your name and >>> there is no reference in the commit message of another author. -- Denys