All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Woodhouse <David.Woodhouse@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"patches@opensource.wolfsonmicro.com" 
	<patches@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ihex: Add support for CS:IP/EIP records
Date: Sat, 11 Sep 2010 11:06:45 +0100	[thread overview]
Message-ID: <20100911100645.GA28571@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1284193744.20200.13.camel@i7.infradead.org>

On Sat, Sep 11, 2010 at 09:29:04AM +0100, David Woodhouse wrote:

> - Which firmware blobs that are *already* in the kernel would need this?
>   Remember, we're not adding new crap to the kernel source tree; new
>   firmware images get added to linux-firmware.git instead.

None to my knowledge, however I don't understand why this would be
relevant to adding new features to ihex2fw?

> - Why make the include_jump code optional? When would we ever *not* want
>   to include such a record -- when does the input ihex file contain such
>   a record that the kernel driver *must* not see because it can't cope
>   with it?

Given that our binary ihex format discards all record type information I
would expect all existing users would be confused if they started seeing
these records so it seems safer to only generate them when required.  It
seems likely that some ihex images will contain jump addresses generated
by their toolchain which do not need to be parsed since the address is
always the same (eg, the address the device uses when brought out of
reset), though none of those in the kernel tree currently seem to.

  reply	other threads:[~2010-09-11 10:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-09 13:40 [PATCH] ihex: Add support for CS:IP/EIP records Mark Brown
2010-09-11  8:29 ` David Woodhouse
2010-09-11 10:06   ` Mark Brown [this message]
2010-09-15 21:27 ` Andrew Morton
2010-09-16 10:41   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100911100645.GA28571@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=David.Woodhouse@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.