All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght
Date: Sun, 12 Sep 2010 14:24:25 +0200	[thread overview]
Message-ID: <201009121424.27604.f.fainelli@gmail.com> (raw)
In-Reply-To: <AANLkTimyy-M8XDZbw5Mv+MikXO4v3+8uKb5QL3dcZ_S3@mail.gmail.com>

Hi Remy,

Le Sunday 12 September 2010 12:01:18, Remy Bohmer a ?crit :
> Hi Florian,
> 
> 2010/4/23 Florian Fainelli <f.fainelli@gmail.com>:
> > It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure
> > it was successfully registered, and at the correct location.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> > index 047902a..4402abb 100644
> > --- a/drivers/usb/host/ehci-pci.c
> > +++ b/drivers/usb/host/ehci-pci.c
> > @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
> >        hcor = (struct ehci_hcor *)((uint32_t) hccr +
> >                        HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> > 
> > +       printf("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
> > +                       (uint32_t)hccr, (uint32_t)hcor,
> > +                      
> > (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase))); +
> 
> I guess I missed this patch...

No problem.

> Should the 'printf' not be a 'debug' statement?

I think so, I will respin this patch. Thanks!
-- 
Florian

      reply	other threads:[~2010-09-12 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23  8:41 [U-Boot] [PATCH] ehci-pci: print hccr, hcor and hc_lenght Florian Fainelli
2010-09-12 10:01 ` Remy Bohmer
2010-09-12 12:24   ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009121424.27604.f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.