From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH 2/7] svm: Run tests with NPT enabled if available
Date: Sun, 12 Sep 2010 16:39:52 +0200
Message-ID: <20100912143952.GF680@8bytes.org>
References: <1284132850-19302-1-git-send-email-joerg.roedel@amd.com> <1284132850-19302-3-git-send-email-joerg.roedel@amd.com> <4C8C991A.6020106@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from 8bytes.org ([88.198.83.132]:33817 "EHLO 8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753073Ab0ILOjx (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 12 Sep 2010 10:39:53 -0400
Content-Disposition: inline
In-Reply-To: <4C8C991A.6020106@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Sep 12, 2010 at 11:10:50AM +0200, Avi Kivity wrote:
>  On 09/10/2010 06:34 PM, Joerg Roedel wrote:
>> This patch adds code to setup a nested page table which is
>> used for all tests.
>>
>
>> +
>> +    printf("NPT detected - running all tests with NPT enabled\n");
>> +
>> +    /*
>> +     * Nested paging supported - Build a nested page table
>> +     * Build the page-table bottom-up and map everything with 2M pages
>> +     */
>> +
>> +    address = 0;
>> +
>> +    /* PTE level */
>
> Conflicts with previous comment - these aren't 2M pages.

Oh right, I used 2M pages in the first version but figured out then that
2MB are not granular enough to write all the NPT tests. Thus I changed
it to 4k pages and forgot to update the comment. I will resend this one.

	Joerg