Re: [PATCH 1/7] davinci: define tnetv107x keypad platform data

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Cyril,

On Mon, Sep 13, 2010 at 12:29:42PM -0400, Cyril Chemparathy wrote:
> This patch adds a definition for the platform data structure needed to
> configure the keypad controller on tnetv107x socs.
> 
> Since this controller is (so far) present only on tnetv107x devices, the data
> structure definition has been kept local to tnetv107x.
> 
> Signed-off-by: Cyril Chemparathy <cyril@ti.com>
> ---
>  arch/arm/mach-davinci/include/mach/tnetv107x.h |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/include/mach/tnetv107x.h b/arch/arm/mach-davinci/include/mach/tnetv107x.h
> index c720647..1ee3035 100644
> --- a/arch/arm/mach-davinci/include/mach/tnetv107x.h
> +++ b/arch/arm/mach-davinci/include/mach/tnetv107x.h
> @@ -37,6 +37,16 @@
>  #include <mach/nand.h>
>  #include <mach/serial.h>
>  
> +struct tnetv107x_keypad_data {
> +	int		*keymap;
> +	const char	**keynames;
> +	int		keymap_size;
> +	int		rows;
> +	int		cols;
> +	u32		debounce;
> +	u32		stable;
> +};
> +

This should be folded into the next patch and probably split into a
separate header file. Also, please consider switching to interface in
linux/input/matrix_keymap.h

Thanks.

- 
Dmitry