Re: [PATCH -v3 3/4 cifs] NTLMv2/NTLMSSP define crypto hash functions and create and send keys needed for key exchange

[Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Tue, 14 Sep 2010 09:15:38 -0500
Shirish Pargaonkar <shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> >> +                             /* 5 is an empirical value, large enought to
> >> +                              * hold authenticate message, max 10 of
> >> +                              * av paris, doamin,user,workstation mames,
> >> +                              * flags etc..
> >> +                              */
> >> +                             ntlmsspblob = kmalloc(5 *
> >> +                                     sizeof(struct _AUTHENTICATE_MESSAGE),
> >> +                                     GFP_KERNEL);
> >
> >                                ^^^^ when does this get freed?
> 
> It gets freed in build_ntlmssp_auth_blob, once the contents are copied.
> 

I don't think it does. It gets passed to that function as the
'pbuffer', and then cast to 'sec_blob'. I don't see where it gets freed
at all.

Even if you're correct though, that's really messy and unclear. I
think it would be best to free it in this function before you exit that
block.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>