From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@infradead.org>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Tom Zanussi <tzanussi@gmail.com>
Subject: Re: [GIT PULL 0/1] perf/core ui browser improvement
Date: Tue, 14 Sep 2010 14:16:11 +0200 [thread overview]
Message-ID: <20100914121611.GD12425@elte.hu> (raw)
In-Reply-To: <1284450852.2275.458.camel@laptop>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Mon, 2010-09-13 at 18:29 -0300, Arnaldo Carvalho de Melo wrote:
> > + 3.00% find [kernel.kallsyms] [k] n_tty_write
>
> > + 3.00% find kernel k n_tty_write
>
> I find that [k] is visually easier to separate from the symbol name.
me too. Something like:
before:
1.08% cc1 libc-2.12.so [.] _int_malloc
0.94% cc1 [kernel.kallsyms] [k] clear_page_c
0.74% cc1 libc-2.12.so [.] _int_free
0.69% cc1 [kernel.kallsyms] [k] page_fault
0.46% cc1 libc-2.12.so [.] malloc_consolidate
after:
1.08% cc1 # libc-2.12.so [.] _int_malloc
0.94% cc1 # kernel [k] clear_page_c
0.74% cc1 # libc-2.12.so [.] _int_free
0.69% cc1 # kernel [k] page_fault
0.46% cc1 # libc-2.12.so [.] malloc_consolidate
Would largely do the trick i think. The comments delineate the DSO
portion from the task portion nicely - while also being a familar
pattern. The column of [.] and [k] gives kernel developers a quick
glance wrt. whether it's kernel or user-space - and it also delineates
the symbol column from the DSO column.
Thanks,
Ingo
next prev parent reply other threads:[~2010-09-14 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 16:34 [GIT PULL 0/1] perf/core ui browser improvement Arnaldo Carvalho de Melo
2010-09-13 16:34 ` [PATCH 1/1] perf ui browser: Don't use windows, slang is enough Arnaldo Carvalho de Melo
2010-09-13 17:48 ` [GIT PULL 0/1] perf/core ui browser improvement Ingo Molnar
2010-09-13 19:07 ` Arnaldo Carvalho de Melo
2010-09-13 20:42 ` Ingo Molnar
2010-09-13 21:29 ` Arnaldo Carvalho de Melo
2010-09-14 7:54 ` Peter Zijlstra
2010-09-14 12:16 ` Ingo Molnar [this message]
2010-09-14 13:07 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914121611.GD12425@elte.hu \
--to=mingo@elte.hu \
--cc=acme@infradead.org \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.