From: Oliver Neukum <oneukum@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Jiri Slaby <jslaby@suse.cz>,
phil@ipom.com, stable@kernel.org, Greg KH <gregkh@suse.de>,
USB list <linux-usb@vger.kernel.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [34-stable regression] USB delay init quirk causes device events loss
Date: Tue, 14 Sep 2010 14:03:00 +0200 [thread overview]
Message-ID: <201009141403.00600.oneukum@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1009131118180.1315-100000@iolanthe.rowland.org>
Am Montag, 13. September 2010, 17:37:49 schrieb Alan Stern:
> Okay, I see the problem. By moving usb_detect_quirks earlier, we end
> up calling usb_disable_autosuspend too soon -- before the
> pm_runtime_enable call in usb_new_device. In 2.6.35 this doesn't
> matter because the implementation of usb_autosuspend_device has
> changed.
>
> So yes, in the end it looks like the best course is to revert this
> patch from 2.6.34.stable. This is unfortunate but I don't see any way
> around it without making changes that aren't present in the current
> kernel. For example, the pm_runtime_set_active and pm_runtime_enable
> calls could also be moved from usb_new_device into
> hub_port_connect_change.
Calling usb_detect_quirks() twice?
Regards
Oliver
next prev parent reply other threads:[~2010-09-14 12:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 11:18 [34-stable regression] USB delay init quirk causes device events loss Jiri Slaby
2010-09-13 14:16 ` Alan Stern
2010-09-13 14:23 ` Jiri Slaby
2010-09-13 14:48 ` Alan Stern
2010-09-13 14:59 ` Jiri Slaby
2010-09-13 15:37 ` Alan Stern
2010-09-13 15:56 ` Greg KH
2010-09-13 16:02 ` Phil Dibowitz
2010-09-13 16:24 ` Alan Stern
2010-09-13 17:03 ` Jiri Slaby
2010-09-13 17:06 ` Greg KH
2010-09-14 12:03 ` Oliver Neukum [this message]
2010-09-14 14:03 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009141403.00600.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=gregkh@suse.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=phil@ipom.com \
--cc=stable@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.