From: "Andrew O. Shadoura" <bugzilla@tut.by>
To: netdev@vger.kernel.org
Cc: Denis Kirjanov <dkirjanov@kernel.org>, ben@decadent.org.uk
Subject: Re: suspend warning with 3c59x
Date: Tue, 14 Sep 2010 18:52:24 +0300 [thread overview]
Message-ID: <201009141852.24775.bugzilla@tut.by> (raw)
In-Reply-To: <4C8F9598.60309@kernel.org>
[-- Attachment #1: Type: Text/Plain, Size: 838 bytes --]
Hello.
On Tuesday 14 September 2010 18:32:40 you wrote:
> I have got a warning with the 3c59.
> (reproduced with pm-suspend)
>
> [ 254.214993] 3c59x 0000:00:0d.0: PME# enabled
> [ 254.215021] BUG: sleeping function called from invalid context at
> kernel/mutex.c:94
> [ 254.215030] in_atomic(): 0, irqs_disabled(): 1, pid: 4875, name: ethtool
> [ 254.215042] Pid: 4875, comm: ethtool Tainted: G
> W 2.6.36-rc3+ #7 [ 254.215049] Call Trace:
> Warning introduced with commit 690a1f2002a3091bd18a501f46c9530f10481463:
> 3c59x: Add ethtool WOL support
> vortex_set_wol protected with a spinlock, but nested acpi_set_WOL acquires
> a mutex inside atomic context. Do we really need to protect .set_wol with
> a vp->lock at all?
Yes, that was my mistake, we do not actually need it.
--
WBR, Andrew
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-09-14 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 15:32 suspend warning with 3c59x Denis Kirjanov
2010-09-14 15:52 ` Andrew O. Shadoura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009141852.24775.bugzilla@tut.by \
--to=bugzilla@tut.by \
--cc=ben@decadent.org.uk \
--cc=dkirjanov@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.