From: Ben Dooks <ben-i2c@fluff.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>,
"Jean Delvare (PC drivers, core)" <khali@linux-fr.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>, Tejun Heo <tj@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly
Date: Wed, 15 Sep 2010 00:20:26 +0100 [thread overview]
Message-ID: <20100914232026.GB7494@trinity.fluff.org> (raw)
In-Reply-To: <20100914073053.GA15611@july>
On Tue, Sep 14, 2010 at 04:30:53PM +0900, Kyungmin Park wrote:
> Don't include asm/gpio.h directly. Use the linux/gpio.h.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
will merge this, unless Jean wants to do it, at the next merge window.
> ---
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index d9aa9a6..0c1cc37 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -15,7 +15,7 @@
> #include <linux/slab.h>
> #include <linux/platform_device.h>
>
> -#include <asm/gpio.h>
> +#include <linux/gpio.h>
>
> /* Toggle SDA by changing the direction of the pin */
> static void i2c_gpio_setsda_dir(void *data, int state)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2010-09-14 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 7:30 [PATCH] I2C-GPIO: Don't include the asm/gpio.h directly Kyungmin Park
2010-09-14 23:20 ` Ben Dooks [this message]
[not found] ` <20100914232026.GB7494-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-09-15 6:35 ` Jean Delvare
2010-09-15 6:35 ` Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2010-09-14 7:30 Kyungmin Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100914232026.GB7494@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=ben-linux@fluff.org \
--cc=hskinnemoen@atmel.com \
--cc=khali@linux-fr.org \
--cc=kmpark@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tj@kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.