From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: eric.dumazet@gmail.com, bphilips@suse.de,
e1000-devel@lists.sourceforge.net, bruce.w.allan@intel.com,
jesse.brandeburg@intel.com, john.ronciak@intel.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
bhutchings@solarflare.com
Subject: Re: [E1000-devel] [PATCH] net: enable GRO by default for vlan devices
Date: Wed, 15 Sep 2010 22:51:46 -0700 (PDT) [thread overview]
Message-ID: <20100915.225146.35823170.davem@davemloft.net> (raw)
In-Reply-To: <20100915181616.578fcd37@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 15 Sep 2010 18:16:16 -0700
> On Thu, 16 Sep 2010 00:28:11 +0200
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
>> BTW, we have a similar problem for bonding ( GRO is disabled )
>>
>> # ethtool -K bond0 gro off
>> # ethtool -K bond0 gro on
>> Cannot set device GRO settings: Invalid argument
>>
>> Same for vlans on top of bond0
>
> Bridge has same problem as well.
Looking this over it should be a simple matter of:
1) Adding the generic get/set gro ethtool ops to bonding
and bridge device ops.
2) Set NETIF_F_GRO in bond/bridge device flags
3) Maybe some minor fiddling with netdev_increment_features
and the flag macros it uses?
Patches welcome :-)
next prev parent reply other threads:[~2010-09-16 5:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 1:50 [PATCH] ixgbe: add GRO to vlan_features Brandon Philips
2010-09-15 4:35 ` David Miller
2010-09-15 16:37 ` [PATCH] vlan: enable GRO if real_dev supports it Brandon Philips
2010-09-15 17:08 ` Eric Dumazet
2010-09-15 17:14 ` David Miller
2010-09-15 17:24 ` Ben Hutchings
2010-09-15 17:29 ` David Miller
2010-09-15 19:24 ` [PATCH] net: enable GRO by default for vlan devices Brandon Philips
2010-09-15 22:03 ` Eric Dumazet
2010-09-15 22:28 ` Eric Dumazet
2010-09-16 1:16 ` Stephen Hemminger
2010-09-16 5:51 ` David Miller [this message]
2010-09-16 6:21 ` [E1000-devel] " Stephen Hemminger
2010-09-16 6:38 ` David Miller
2010-09-16 6:42 ` Eric Dumazet
2010-09-16 8:11 ` [PATCH] ethtool: change ethtool_set_gro() to use ethtool_op_get_rx_csum Eric Dumazet
2010-09-17 18:57 ` David Miller
2010-09-17 19:25 ` [PATCH] bonding: enable gro by default Eric Dumazet
2010-09-17 23:54 ` David Miller
2010-09-16 5:32 ` [PATCH] net: enable GRO by default for vlan devices David Miller
2010-09-15 18:59 ` [PATCH] vlan: enable GRO if real_dev supports it Brandon Philips
2010-09-15 16:38 ` [PATCH] ixgbe: add GRO to vlan_features Brandon Philips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915.225146.35823170.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=bphilips@suse.de \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eric.dumazet@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.