Re: [PATCH] mfd: ab8500: update kconfig for ab8500 core driver

[Randy Dunlap <randy.dunlap@oracle.com>]

On Wed, 15 Sep 2010 16:53:43 +0530 Arun Murthy wrote:

> This patch add a dependancy for ab8500-core driver so as to depend on
> u8500 platform.
> 
> This patch also fixes the build issues(powerpc_allyesconfig) for the
> patch 03f582a93ecca6e9584b622570022abf08ed03ec (misc: Add ab8500 pwm
> driver)

Please list build errors/warnings that are fixed in your patch description.

This patch will certainly keep i386 builds from failing, like I saw
yesterday.  However, since this driver uses some spi_*() functions,
it should also depend on SPI_MASTER IMO.
See this patch:  http://lkml.org/lkml/2010/9/14/412


> Signed-off-by: Arun Murthy <arun.murthy@stericsson.com>
> Acked-by: Linus Walleij <linus.walleij@stericsson.com>
> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index fbfe14a..841ce47 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -475,7 +475,7 @@ config EZX_PCAP
>  
>  config AB8500_CORE
>  	bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
> -	depends on GENERIC_HARDIRQS && ABX500_CORE
> +	depends on GENERIC_HARDIRQS && ABX500_CORE && ARCH_U8500
>  	select MFD_CORE
>  	help
>  	  Select this option to enable access to AB8500 power management
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***