From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56812 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ovrlc-0000ZO-HE
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 09:11:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Ovrlb-0000wV-3r
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 09:11:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43346)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <mst@redhat.com>) id 1Ovrla-0000wB-SX
	for qemu-devel@nongnu.org; Wed, 15 Sep 2010 09:11:15 -0400
Date: Wed, 15 Sep 2010 15:05:13 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v2 2/9] pcie: helper functions for pcie
	extended capability.
Message-ID: <20100915130513.GD31520@redhat.com>
References: <cover.1283931134.git.yamahata@valinux.co.jp>
	<20d8ef39308fd49bf95d83485402fc20499674d3.1283931134.git.yamahata@valinux.co.jp>
	<20100908103122.GF23051@redhat.com>
	<20100915055001.GA29979@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100915055001.GA29979@valinux.co.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: skandasa@cisco.com, adhyas@gmail.com, etmartin@cisco.com, qemu-devel@nongnu.org, wexu2@cisco.com

On Wed, Sep 15, 2010 at 02:50:01PM +0900, Isaku Yamahata wrote:
> On Wed, Sep 08, 2010 at 01:31:22PM +0300, Michael S. Tsirkin wrote:
> > > +
> > > +static void pcie_notify(PCIDevice *dev, uint16_t vector,
> > > +                        bool trigger, int level)
> > > +{
> > > +    /* masking/masking interrupt is handled by upper layer.
> > > +     * i.e. msix_notify() for MSI-X
> > > +     *      msi_notify()  for MSI
> > > +     *      pci_set_irq() for INTx
> > > +     */
> > 
> > So this will send another interrupt when level is 0?
> 
> Yes. The condition that triggers MSI-X/MSI can be different from
> the one that asserts INTx as you can see it in the following code.
> trigger and level are set independently.

Looks like a bug ... but we are better off splitting this
to assert/deassert case as I suggested separately, anyway.

> -- 
> yamahata