From: Tony Lindgren <tony@atomide.com>
To: "archit@ti.com" <archit@ti.com>
Cc: tomi.valkeinen@nokia.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 0/2] OMAP: DSS2: Framework to handle omap version specific DSS features
Date: Wed, 15 Sep 2010 10:59:21 -0700 [thread overview]
Message-ID: <20100915175921.GE4174@atomide.com> (raw)
In-Reply-To: <1284559794-4771-1-git-send-email-archit@ti.com>
* archit@ti.com <archit@ti.com> [100915 07:00]:
> From: Archit Taneja <archit@ti.com>
>
> This is a simple approach to prevent scattered cpu_is_omapxxxx checks
> in DSS2 by bringing all omap version specific DSS features/values to one
> single place, initialize them and expose a set of functions to DSS2 driver
> files which return the value/existance of a feature.
Glad to hear. We should absolutely not use cpu_is_omapxxxx checks
anywhere in the drivers. The drivers should be arch independent.
Basically any driver using those is broken from Linux point of view.
The current mess is:
$ grep -r cpu_is_omap drivers/ | wc -l
139
The right way to replace those is to pass feature flags from
the platform_data.
Tony
next prev parent reply other threads:[~2010-09-15 17:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 14:09 [PATCH v4 0/2] OMAP: DSS2: Framework to handle omap version specific DSS features archit
2010-09-15 14:09 ` [PATCH v4 1/2] OMAP: DSS2: Introduce dss_features files archit
2010-10-07 7:09 ` Tomi Valkeinen
2010-10-07 7:37 ` Taneja, Archit
2010-10-07 7:42 ` Tomi Valkeinen
2010-10-07 8:16 ` Taneja, Archit
2010-09-15 14:09 ` [PATCH v4 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code archit
2010-09-21 7:51 ` Taneja, Archit
2010-09-15 17:59 ` Tony Lindgren [this message]
2010-10-07 8:32 ` [PATCH v4 0/2] OMAP: DSS2: Framework to handle omap version specific DSS features Tomi Valkeinen
2010-10-07 8:27 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100915175921.GE4174@atomide.com \
--to=tony@atomide.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.