Re: CSP implementation for MCAP

["José Antonio Santos Cadenas" <santoscadenas@gmail.com>]

El Thursday 16 September 2010 14:39:00 Johan Hedberg escribió:
> Hi Elvis,
> 
> On Wed, Sep 15, 2010, Elvis Pfützenreuter wrote:
> > > This is the repository for the CSP implementation, rebased over the
> > > recently accepted MCAP, for your appreciation:
> > > 
> > > git://gitorious.org/bluez-epx/bluez-epx.git csp
> > > 
> > > or
> > > 
> > > http://www.gitorious.org/bluez-epx/bluez-epx/commits/csp--
> > 
> > And I am happy to announce that this CSP implementation passed on PTS
> > 
> > :) Fixes are on topmost patch of the repository.
> 
> Good to hear about the progress with the PTS :)
> 
> Unfortunately you'll need to rebase again since I pushed some cleanups
> to the MCAP code. Could you also get rid of the unnecessary
> double-pointers and type casts which aren't needed anymore now that
> mcap_send_data accepts void *.

There are also a lot of (! condition) with an extra space between the ! and 
the condition variable.

Also some use of g_malloc0 instead of g_new0. About this issue, remember that 
g_new0 initializes all the structure with 0 so the initialization don't need 
to do for some fields in mcap_sync_init function.

Regards.

> 
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html