diff for duplicates of <20100916151736.GC14165@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index b5d0654..de5dc8b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -354,7 +354,7 @@ Does this have to be a hard wait ? > + twl4030_madc_write(the_madc, method->avg, ch_lsb); > + } > + -> + if ((req->type == TWL4030_MADC_IRQ_ONESHOT) && (req->func_cb != NULL)) { +> + if ((req->type = TWL4030_MADC_IRQ_ONESHOT) && (req->func_cb != NULL)) { Extra and unnecessary (). Please remove. @@ -366,7 +366,7 @@ Extra and unnecessary (). Please remove. > + } > + > + /* With RT method we should not be here anymore */ -> + if (req->method == TWL4030_MADC_RT) { +> + if (req->method = TWL4030_MADC_RT) { > + ret = -EINVAL; > + goto out; > + } @@ -573,9 +573,9 @@ There is no write function. Why S_IWUSR ? > + goto err_pdata; > + } > + madc->hwmon_dev = &pdev->dev; -> + madc->imr = (pdata->irq_line == 1) ? +> + madc->imr = (pdata->irq_line = 1) ? > + TWL4030_MADC_IMR1 : TWL4030_MADC_IMR2; -> + madc->isr = (pdata->irq_line == 1) ? +> + madc->isr = (pdata->irq_line = 1) ? > + TWL4030_MADC_ISR1 : TWL4030_MADC_ISR2; > + madc->hwmon_dev = hwmon_device_register(&pdev->dev); @@ -838,3 +838,8 @@ Extra blank line here, causing a whitespace error when integrating. Please remov > lm-sensors mailing list > lm-sensors@lm-sensors.org > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + +_______________________________________________ +lm-sensors mailing list +lm-sensors@lm-sensors.org +http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 32251b9..c6331c2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01284632604-25303-1-git-send-email-j-keerthy@ti.com\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module\0" - "Date\0Thu, 16 Sep 2010 08:17:36 -0700\0" + "Subject\0Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030\0" + "Date\0Thu, 16 Sep 2010 15:17:36 +0000\0" "To\0Keerthy <j-keerthy@ti.com>\0" "Cc\0linux-omap@vger.kernel.org <linux-omap@vger.kernel.org>" lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org> @@ -364,7 +364,7 @@ "> + twl4030_madc_write(the_madc, method->avg, ch_lsb);\n" "> + }\n" "> +\n" - "> + if ((req->type == TWL4030_MADC_IRQ_ONESHOT) && (req->func_cb != NULL)) {\n" + "> + if ((req->type = TWL4030_MADC_IRQ_ONESHOT) && (req->func_cb != NULL)) {\n" "\n" "Extra and unnecessary (). Please remove.\n" "\n" @@ -376,7 +376,7 @@ "> + }\n" "> +\n" "> + /* With RT method we should not be here anymore */\n" - "> + if (req->method == TWL4030_MADC_RT) {\n" + "> + if (req->method = TWL4030_MADC_RT) {\n" "> + ret = -EINVAL;\n" "> + goto out;\n" "> + }\n" @@ -583,9 +583,9 @@ "> + goto err_pdata;\n" "> + }\n" "> + madc->hwmon_dev = &pdev->dev;\n" - "> + madc->imr = (pdata->irq_line == 1) ?\n" + "> + madc->imr = (pdata->irq_line = 1) ?\n" "> + TWL4030_MADC_IMR1 : TWL4030_MADC_IMR2;\n" - "> + madc->isr = (pdata->irq_line == 1) ?\n" + "> + madc->isr = (pdata->irq_line = 1) ?\n" "> + TWL4030_MADC_ISR1 : TWL4030_MADC_ISR2;\n" "> + madc->hwmon_dev = hwmon_device_register(&pdev->dev);\n" "\n" @@ -847,6 +847,11 @@ "> _______________________________________________\n" "> lm-sensors mailing list\n" "> lm-sensors@lm-sensors.org\n" - > http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + "> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors\n" + "\n" + "_______________________________________________\n" + "lm-sensors mailing list\n" + "lm-sensors@lm-sensors.org\n" + http://lists.lm-sensors.org/mailman/listinfo/lm-sensors -1427025e83929922a00deac982717cc9affd4f16a0f828703b7ffee08226846c +1fd669505cb8f02885bc002b624a2ed5d7f5fe398477eae7395655c5da0fbc52
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.