From: Tony Lindgren <tony@atomide.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings
Date: Thu, 16 Sep 2010 12:27:58 -0700 [thread overview]
Message-ID: <20100916192758.GL29610@atomide.com> (raw)
In-Reply-To: <1282856209-15645-5-git-send-email-manjugk@ti.com>
* G, Manjunath Kondaiah <manjugk@ti.com> [100826 13:50]:
> From: Manjunatha GK <manjugk@ti.com>
>
> This patch fixes miscellaneous sparse warnings in mach-omap2.
>
> arch/arm/mach-omap2/board-am3517evm.c:141:17: warning: Initializer entry defined twice
> arch/arm/mach-omap2/board-am3517evm.c:142:18: also defined here
>
> arch/arm/mach-omap2/irq.c:50:35: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Manjunatha GK <manjugk@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Nishanth Menon <nm@ti.com>
> ---
> arch/arm/mach-omap2/board-am3517evm.c | 1 -
> arch/arm/mach-omap2/irq.c | 2 +-
> 2 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-am3517evm.c b/arch/arm/mach-omap2/board-am3517evm.c
> index ae22ea8..b091741 100644
> --- a/arch/arm/mach-omap2/board-am3517evm.c
> +++ b/arch/arm/mach-omap2/board-am3517evm.c
> @@ -139,7 +139,6 @@ static void am3517_evm_ethernet_init(struct emac_platform_data *pdata)
> static struct i2c_board_info __initdata am3517evm_i2c1_boardinfo[] = {
> {
> I2C_BOARD_INFO("s35390a", 0x30),
> - .type = "s35390a",
> },
> };
OK, I2C_BOARD_INFO sets it too.
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 26aeef5..02fd942 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -47,7 +47,7 @@ static struct omap_irq_bank {
> } __attribute__ ((aligned(4))) irq_banks[] = {
> {
> /* MPU INTC */
> - .base_reg = 0,
> + .base_reg = (void __iomem *)0,
> .nr_irqs = 96,
> },
> };
The base_reg line you can remove, the static data area gets zeroed
during init.
Regards,
Tony
next prev parent reply other threads:[~2010-09-16 19:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 20:56 [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 01/11] OMAP: mach-omap2: Fix incorrect assignment warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 02/11] OMAP: mach-omap2: Fix static declaration warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 03/11] OMAP: mach-omap2: Fix static function warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 04/11] OMAP: mach-omap2: Fix miscellaneous sparse warnings G, Manjunath Kondaiah
2010-09-16 19:27 ` Tony Lindgren [this message]
2010-09-20 5:57 ` G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 05/11] OMAP: plat-omap: Fix static function warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 06/11] OMAP: McBSP: Fix static function warning G, Manjunath Kondaiah
2010-08-31 7:34 ` Peter Ujfalusi
2010-08-26 20:56 ` [PATCH 07/11] OMAP: HSMMC: Fix unused variable warning G, Manjunath Kondaiah
2010-08-27 9:03 ` kishore kadiyala
2010-08-26 20:56 ` [PATCH 08/11] OMAP: NAND: Fix static declaration warning G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 09/11] TWL CORE: Fix sparse warning G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 10/11] TWL IRQ: Fix fucntion declaration warnings G, Manjunath Kondaiah
2010-08-26 20:56 ` [PATCH 11/11] TWL4030: Codec: Fix fucntion declaration error G, Manjunath Kondaiah
2010-08-31 7:32 ` Peter Ujfalusi
2010-09-16 19:34 ` [PATCH 00/11] OMAP2/TWL: Fix Sparse warnings Tony Lindgren
2010-09-20 5:58 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916192758.GL29610@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.