From: "John W. Linville" <linville@tuxdriver.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: jirislaby@gmail.com, mickflemm@gmail.com, lrodriguez@atheros.com,
br1@einfach.org, linux-wireless@vger.kernel.org,
ath5k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath5k: reorder base.c to remove fwd decls
Date: Thu, 16 Sep 2010 15:36:52 -0400 [thread overview]
Message-ID: <20100916193652.GE7221@tuxdriver.com> (raw)
In-Reply-To: <1284231996-29010-1-git-send-email-me@bobcopeland.com>
On Sat, Sep 11, 2010 at 03:06:36PM -0400, Bob Copeland wrote:
> This change reorganizes the main ath5k file in order to re-group
> related functions and remove most of the forward declarations
> (from 61 down to 3). This is, unfortunately, a lot of churn, but
> there should be no functional changes.
>
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
> ---
>
> Worth the churn? Is there any way to do this kind of patch that
> doesn't suck?
Apparently not...
Well, I hate to ask for a rebase -- but this doesn't apply anymore!
I would just fix it up, but that offending hunk is 2500 lines or so...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-09-16 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 19:06 [PATCH] ath5k: reorder base.c to remove fwd decls Bob Copeland
2010-09-11 19:16 ` [ath5k-devel] " Bob Copeland
2010-09-13 1:33 ` Bruno Randolf
2010-09-16 19:36 ` John W. Linville [this message]
2010-09-16 23:18 ` Bob Copeland
2010-09-17 2:37 ` Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916193652.GE7221@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=br1@einfach.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.