From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens@suse.cz, "Axboe <axboe"@kernel.dk,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/3] BDI handling fixes
Date: Thu, 16 Sep 2010 19:47:42 -0400 [thread overview]
Message-ID: <20100916234742.GA26030@infradead.org> (raw)
In-Reply-To: <1284677051-28564-1-git-send-email-jack@suse.cz>
On Fri, Sep 17, 2010 at 12:44:08AM +0200, Jan Kara wrote:
>
> Hi,
>
> series of these three patches fixes the warning in __mark_inode_dirty()
> which happens when I do e.g. touch /dev/zero. The first two patches should
> be obvious enough and probably worth merging independently of the third
> patch. The third patch is upto a discussion whether we want to solve the
> problem that way or differently. Christoph, I know we spoke at LSF that
> inode_to_bdi() could be a per-sb method but the current version of the
> patch seems clean enough to me that we could maybe go even without the
> special callback?
Feel free to go with the simpler one. But what I think really needs to
be changes is the no writeback flag - it's exactly the wrong way around.
Instead just add a flag to allow writeback for the block device and
fs-specific bdi structures.
next prev parent reply other threads:[~2010-09-16 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 22:44 [PATCH 0/3] BDI handling fixes Jan Kara
2010-09-16 22:44 ` [PATCH 1/3] bdi: Initialize noop_backing_dev_info properly Jan Kara
2010-09-16 22:44 ` [PATCH 2/3] char: Mark /dev/zero and /dev/kmem as not capable of writeback Jan Kara
2010-09-16 22:44 ` [PATCH 3/3] bdi: Fix warnings in __mark_inode_dirty for /dev/zero and friends Jan Kara
2010-09-16 23:47 ` Christoph Hellwig [this message]
2010-09-17 12:52 ` [PATCH 0/3] BDI handling fixes Jan Kara
2010-09-17 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916234742.GA26030@infradead.org \
--to=hch@infradead.org \
--cc="Axboe <axboe"@kernel.dk \
--cc=Jens@suse.cz \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.