Re: The segment fault with NULL point using when recovering failure

From: Dave Chinner <david@fromorbit.com>
To: Mike Gao <ygao.linux@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: The segment fault with NULL point using when recovering failure
Date: Fri, 17 Sep 2010 11:44:12 +1000	[thread overview]
Message-ID: <20100917014412.GK24409@dastard> (raw)
In-Reply-To: <AANLkTimR-dBLmQQ-Nh0mmjHJMfFidePKxfO6P76y48n8@mail.gmail.com>

On Wed, Sep 15, 2010 at 10:59:07AM -0500, Mike Gao wrote:
> xlog_recover_process_iunlinks(
>     xlog_t        *log)
> {
>                 /*
>                  * Reacquire the agibuffer and continue around
>                  * the loop. This should never fail as we know
>                  * the buffer was good earlier on.
>                  */
>                 error = xfs_read_agi(mp, NULL, agno, &agibp);
>                 ASSERT(error == 0);
>                 agi = XFS_BUF_TO_AGI(agibp);
> 
> }
> If no defined DEBUG, ASSERT will not work and agibp could be ZERO if there
> is a error in xfs_read_agi.
> And the comment shouldn't say it never fail because  xfs_read_agi will
> return error in function and it does when there is forced shutdown.

Have you seen a failure here?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs