From: Andy Whitcroft <apw@shadowen.org>
To: Sven Eckelmann <sven.eckelmann@gmx.de>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] batman-adv: unicast fragmentation enhancements
Date: Fri, 17 Sep 2010 15:48:11 +0100 [thread overview]
Message-ID: <20100917144811.GA3805@shadowen.org> (raw)
In-Reply-To: <201009170027.16080.sven.eckelmann@gmx.de>
On Fri, Sep 17, 2010 at 12:27:13AM +0200, Sven Eckelmann wrote:
> Andreas Langer wrote:
> > Sven, any idea why checkpatch (0.31)b do this ?
> >
> > ERROR: space prohibited after that '-' (ctx:WxW)
> > #10: FILE: batman-adv/routing.c:1146:
> > + uni_diff = sizeof(struct unicast_frag_packet) - hdr_len;
>
> Because... what the heck? Usually it says that you should use consistent
> spaces around '-'. So better use spaces in patch 1 and 6 and don't remove the
> space before hdr_len as you did now.
Because it is wrong. I believe that I've fixed that one up in my
development tree. Could you confirm it is correctly left alone with the
version below:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
> My version from linux-next (today) is 0.30 and doesn't have a problem with
> spaces around those '-' (but with your version of the patches). The
> checkpatch.pl-testing also don't have the problem.
>
> I would guess that it was a regression in checkpatch.pl. Maybe Andy Whitcroft
> knows more about it
-apw
next prev parent reply other threads:[~2010-09-17 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 21:59 [B.A.T.M.A.N.] batman-adv: unicast fragmentation enhancements Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: restructure fragmentation to handle batman unicast packets Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: add frag_ prefix to all fragmentation related functions Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: move skb reassembly of fragmented packets into dedicated function Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv:remove redundant is_my_mac() check in route_unicast_packet - callers deal with it Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: fragment forwarded packets Andreas Langer
2010-09-16 22:00 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: reassemble fragmented skb if mtu allows it Andreas Langer
2010-09-16 22:43 ` Andreas Langer
2010-09-16 22:27 ` [B.A.T.M.A.N.] batman-adv: unicast fragmentation enhancements Sven Eckelmann
2010-09-17 14:48 ` Andy Whitcroft [this message]
2010-09-17 14:54 ` Sven Eckelmann
2010-09-25 10:13 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2010-09-10 16:47 Andreas Langer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917144811.GA3805@shadowen.org \
--to=apw@shadowen.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven.eckelmann@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.