From: "Hans J. Koch" <hjk@linutronix.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Hans J. Koch" <hjk@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] uio: Statically allocate uio_class and use class .dev_attrs.
Date: Fri, 17 Sep 2010 22:57:37 +0200 [thread overview]
Message-ID: <20100917205737.GE2522@local> (raw)
In-Reply-To: <alpine.LFD.2.00.1009172237080.2416@localhost6.localdomain6>
On Fri, Sep 17, 2010 at 10:37:26PM +0200, Thomas Gleixner wrote:
> On Tue, 14 Sep 2010, Eric W. Biederman wrote:
> >
> > Instead of adding uio class attributes manually after the uio device has
> > been created and we have sent a uevent to userspace, use the class
> > attribute mechanism. This removes races and makes the code simpler.
> >
> > At the same time don't bother to dynamically allocate a struct class for
> > uio, just declare one statically. Less code is needed and it is easier
> > to set the class parameters.tune the class
> >
> > Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Hans J. Koch <hjk@linutronix.de>
next prev parent reply other threads:[~2010-09-17 20:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 18:35 [PATCH 0/5] Uio enhancements Eric W. Biederman
2010-09-14 18:36 ` [PATCH 1/5] uio: Fix lack of locking in init_uio_class Eric W. Biederman
2010-09-17 20:32 ` Thomas Gleixner
2010-09-17 20:49 ` Hans J. Koch
2010-09-14 18:36 ` [PATCH 2/5] uio: Don't clear driver data Eric W. Biederman
2010-09-17 20:33 ` Thomas Gleixner
2010-09-17 20:50 ` Hans J. Koch
2010-09-14 18:37 ` [PATCH 3/5] uio: Cleanup irq handling Eric W. Biederman
2010-09-17 20:34 ` Thomas Gleixner
2010-09-17 20:51 ` Hans J. Koch
2010-09-14 18:38 ` [PATCH 4/5] uio: Support 2^MINOR_BITS minors Eric W. Biederman
2010-09-17 20:36 ` Thomas Gleixner
2010-09-17 20:57 ` Hans J. Koch
2010-09-17 21:09 ` Greg KH
2010-09-21 21:08 ` Greg KH
2010-09-21 21:38 ` Thomas Gleixner
2010-09-21 21:56 ` Greg KH
2010-09-21 22:21 ` Eric W. Biederman
2010-09-21 22:26 ` Thomas Gleixner
2010-09-14 18:38 ` [PATCH 5/5] uio: Statically allocate uio_class and use class .dev_attrs Eric W. Biederman
2010-09-17 20:37 ` Thomas Gleixner
2010-09-17 20:57 ` Hans J. Koch [this message]
2010-09-17 20:59 ` [PATCH 0/5] Uio enhancements Hans J. Koch
2010-09-20 7:19 ` [PATCH 0/5] uio hotplug support Eric W. Biederman
2010-09-20 7:21 ` [PATCH 1/5] uio: Simplify the lifetime logic of struct uio_device Eric W. Biederman
2010-09-20 7:21 ` [PATCH 2/5] uio: Kill unused vma_count Eric W. Biederman
2010-09-20 7:23 ` [PATCH 3/5] uio: Remove unused uio_info mmap method Eric W. Biederman
2010-09-20 7:23 ` [PATCH 4/5] libunload: A library to help remove open files Eric W. Biederman
2010-09-20 7:24 ` [PATCH 5/5] uio: Implement hotunplug support, using libunload Eric W. Biederman
2010-09-24 10:55 ` Hans J. Koch
2010-09-24 17:11 ` Eric W. Biederman
2010-09-25 2:06 ` [PATCH] uio: Fix accidentally changed return value in uio_read Eric W. Biederman
2010-09-24 10:45 ` [PATCH 0/5] uio hotplug support Hans J. Koch
2010-09-24 17:14 ` Eric W. Biederman
2010-09-24 17:31 ` Hans J. Koch
2010-09-24 18:38 ` Eric W. Biederman
2010-09-25 0:05 ` Eric W. Biederman
2010-09-25 0:33 ` Greg KH
2010-09-25 1:54 ` Eric W. Biederman
2010-09-26 19:21 ` Greg KH
2010-09-26 22:46 ` [PATCH 1/5] uio: Simplify the lifetime logic of struct uio_device Eric W. Biederman
2010-09-30 22:00 ` Hans J. Koch
2010-09-26 22:47 ` [PATCH 2/5] uio: Kill unused vma_count Eric W. Biederman
2010-09-26 22:48 ` [PATCH 3/5] uio: Remove unused uio_info mmap method Eric W. Biederman
2010-10-04 9:26 ` Hans J. Koch
2010-09-26 22:48 ` [PATCH 4/5] libunload: A library to help remove open files Eric W. Biederman
2010-10-04 9:56 ` Hans J. Koch
2010-09-26 22:49 ` [PATCH 5/5] uio: Implement hotunplug support, using libunload Eric W. Biederman
2010-10-04 10:47 ` Hans J. Koch
2010-10-04 12:34 ` Hans J. Koch
2010-10-04 18:19 ` Eric W. Biederman
2010-10-04 18:52 ` Hans J. Koch
2010-09-26 22:49 ` [PATCH 6/5] uio: Fix accidentally changed return value in uio_read Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100917205737.GE2522@local \
--to=hjk@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.