From: Andrew Morton <akpm@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Namhyung Kim <namhyung@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Phillip Lougher <phillip@lougher.demon.co.uk>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] init: add sys-wrapper.h
Date: Sat, 18 Sep 2010 02:50:57 -0700 [thread overview]
Message-ID: <20100918025057.ae9c3ce3.akpm@linux-foundation.org> (raw)
In-Reply-To: <201009181127.47063.arnd@arndb.de>
On Sat, 18 Sep 2010 11:27:46 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 17 September 2010, Andrew Morton wrote:
> > > - int err = sys_mount(name, "/root", fs, flags, data);
> > > + int err = kernel_sys_mount(name, "/root", fs, flags, data);
> >
> > It would be good if we could arrange for all kernel syscalls to use
> > the wrappers. ie: cause a direct call to sys_mount() to not compile?
> >
> > I don't know how practical that would be.
>
> One common reason to call a sys_* function is to implement another
> system call, e.g. sys_socketcall calling sys_socket or
> compat_sys_timer_create calling sys_timer_create.
>
> I think in those cases we don't really want to go through another
> wrapper.
The overhead is zero in the case of sys_socket() and somewhat non-zero
in the case of sys_timer_create(). I can't immediately see a
convenient way of reducing "somewhat" to zero.
next prev parent reply other threads:[~2010-09-18 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 15:30 [PATCH v4 0/2] init cleanups Namhyung Kim
2010-08-31 15:30 ` [PATCH v4 1/2] init: add sys-wrapper.h Namhyung Kim
2010-09-17 21:40 ` Andrew Morton
2010-09-18 9:27 ` Arnd Bergmann
2010-09-18 9:50 ` Andrew Morton [this message]
2010-08-31 15:30 ` [PATCH v4 2/2] init: use kern_sys_* wrappers instead of syscall Namhyung Kim
2010-09-02 3:26 ` [PATCH v4 2/2] init: use kernel_sys_* " Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100918025057.ae9c3ce3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=phillip@lougher.demon.co.uk \
--cc=sam@ravnborg.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.