From: Sven Eckelmann <sven.eckelmann@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Marek Lindner <lindner_marek@yahoo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 9/9] batman-adv: count batman_if list queries as reference
Date: Sat, 18 Sep 2010 17:21:43 +0200 [thread overview]
Message-ID: <201009181721.44244.sven.eckelmann@gmx.de> (raw)
In-Reply-To: <201009181642.08297.lindner_marek@yahoo.de>
[-- Attachment #1: Type: Text/Plain, Size: 925 bytes --]
Marek Lindner wrote:
> On Friday 17 September 2010 19:27:06 Sven Eckelmann wrote:
> > The return of get_batman_if_by_netdev and get_active_batman_if leaks a
> > pointer from the rcu protected list of interfaces. We must protect it to
> > prevent a too early release of the memory. Those functions must increase
> > the reference counter before rcu_read_unlock or it may be to late to
> > prevent a free.
>
> It seems this patch does not properly deal with bat_priv->primary_if.
> Please review my revised patch and let me know if you think it is ok.
As said before, this patch should not count primary_if by design (see the
commit message). I would say that your changes should be an extra patch.
I will split that stuff and send it as extra patches. Your patch itself has
the problem that it increases the refcnt through get_active_batman_if, but
doesn't reduce it at the end.
Best regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2010-09-18 15:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 15:40 [B.A.T.M.A.N.] [PATCHv2 0/9] RCU locking patches Sven Eckelmann
2010-09-17 15:40 ` [B.A.T.M.A.N.] [PATCH 1/9] batman-adv: Introduce if_list_lock to protect if_list Sven Eckelmann
2010-09-17 15:40 ` [B.A.T.M.A.N.] [PATCH 2/9] batman-adv: Protect update side of gw_list Sven Eckelmann
2010-09-17 15:40 ` [B.A.T.M.A.N.] [PATCH 3/9] batman-adv: Always protect list_for_each_entry_rcu with RCU Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 4/9] batman-adv: Remove unneeded rcu_read_lock Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 5/9] batman-adv: Use synchronize_rcu instead of call_rcu Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 6/9] batman-adv: Use refcnt to track usage count of gw_node Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 7/9] batman-adv: Use refcnt to track usage count of batman_if Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 8/9] batman-adv: count election of gateway as reference Sven Eckelmann
2010-09-17 15:41 ` [B.A.T.M.A.N.] [PATCH 9/9] batman-adv: count batman_if list queries " Sven Eckelmann
2010-09-17 17:27 ` [B.A.T.M.A.N.] [PATCHv2 " Sven Eckelmann
2010-09-18 14:42 ` Marek Lindner
2010-09-18 14:42 ` [B.A.T.M.A.N.] [PATCH] " Marek Lindner
2010-09-18 15:21 ` Sven Eckelmann [this message]
2010-09-18 15:23 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Track references of batman_if in set_primary_if Sven Eckelmann
2010-09-18 15:23 ` [B.A.T.M.A.N.] [PATCH 2/2] Introduce update_primary_addr to update mac address Sven Eckelmann
2010-09-18 15:41 ` [B.A.T.M.A.N.] [PATCHv2 9/9] batman-adv: count batman_if list queries as reference Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009181721.44244.sven.eckelmann@gmx.de \
--to=sven.eckelmann@gmx.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=lindner_marek@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.