diff for duplicates of <20100918204112.GA6236@bicker> diff --git a/a/1.txt b/N1/1.txt index 85fbffb..e98a845 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -31,14 +31,14 @@ a little annoying. > /* Tell the MSD to open */ > - if (wlandev->open != NULL) { > - result = wlandev->open(wlandev); -> - if (result = 0) { +> - if (result == 0) { > - netif_start_queue(wlandev->netdev); > - wlandev->state = WLAN_DEVICE_OPEN; > - } > - } else { > - result = -EAGAIN; -> + if (wlandev->open = NULL) { -> + printk(KERN_ERR "Sorry, got wlandev->open = NULL.\n"); +> + if (wlandev->open == NULL) { +> + printk(KERN_ERR "Sorry, got wlandev->open == NULL.\n"); This printk is not needed. I haven't looked at this code, but if the user can trigger this error message then it can be used to flood diff --git a/a/content_digest b/N1/content_digest index 6100a84..9b2160a 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01284834652-26171-1-git-send-email-lkml@Think-Future.com\0" "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0Re: [PATCH] Staging: wlan-ng: p80211netdev.c cleanup\0" - "Date\0Sat, 18 Sep 2010 20:41:12 +0000\0" + "Date\0Sat, 18 Sep 2010 22:41:12 +0200\0" "To\0Nils Radtke <lkml@think-future.com>\0" "Cc\0gregkh@suse.de" kernel-janitors@vger.kernel.org @@ -42,14 +42,14 @@ "> \t/* Tell the MSD to open */\n" "> -\tif (wlandev->open != NULL) {\n" "> -\t\tresult = wlandev->open(wlandev);\n" - "> -\t\tif (result = 0) {\n" + "> -\t\tif (result == 0) {\n" "> -\t\t\tnetif_start_queue(wlandev->netdev);\n" "> -\t\t\twlandev->state = WLAN_DEVICE_OPEN;\n" "> -\t\t}\n" "> -\t} else {\n" "> -\t\tresult = -EAGAIN;\n" - "> +\tif (wlandev->open = NULL) {\n" - "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open = NULL.\\n\");\n" + "> +\tif (wlandev->open == NULL) {\n" + "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open == NULL.\\n\");\n" "\n" "This printk is not needed. I haven't looked at this code, but if the\n" "user can trigger this error message then it can be used to flood\n" @@ -124,4 +124,4 @@ "regards,\n" dan carpenter -5d22037e2b48245f8762375488a10869c1654ba99612b8150e81b49d5d1ff9e2 +cc1c0849ac11ae3ab4668c9591ae0a88041b9df67fad79a8647cee1bb4e090fe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.