All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] New/undocumented ABI attributes in w83795 driver
Date: Sun, 19 Sep 2010 21:34:53 +0000	[thread overview]
Message-ID: <20100919213453.GA31435@ericsson.com> (raw)
In-Reply-To: <20100919163321.GA30847@ericsson.com>

Hi Jean,

On Sun, Sep 19, 2010 at 03:40:24PM -0400, Jean Delvare wrote:
> Hi Guenter,
> 
> On Sun, 19 Sep 2010 09:33:22 -0700, Guenter Roeck wrote:
> > I had a closer look into the w83795 driver - this time trying to ignore
> > coding style problems ;) - and noticed that there are several attributes
> > which are not defined in the ABI.
> 
> Correct. I've seen them too, but they are not in the part of the driver
> I carefully reviewed and tested yet. I think most (all?) of them are in
> the automatic fan speed control area. The few ones which were in the
> monitoring part of the driver, I have fixed already, hopefully.
> 
Just wondering - does it make sense to push the untested parts of the driver
into the kernel, or would it be better to keep that out until you had a chance 
to test it ? Especially since those parts go beyond monitoring and actually
control something.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-09-19 21:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-19 16:33 [lm-sensors] New/undocumented ABI attributes in w83795 driver Guenter Roeck
2010-09-19 19:40 ` Jean Delvare
2010-09-19 21:34 ` Guenter Roeck [this message]
2010-10-28 15:11 ` Jean Delvare
2010-10-28 15:25 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100919213453.GA31435@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.