From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: cpu hotplug Date: Mon, 20 Sep 2010 08:50:17 +0200 Message-ID: <20100920065017.GE3008@redhat.com> References: <20100919143611.GW3008@redhat.com> <1284909384.9521.228.camel@frechmops.schnuffi.conrad.localdomain> <20100919151916.GX3008@redhat.com> <1284910638.9521.242.camel@frechmops.schnuffi.conrad.localdomain> <20100919154113.GZ3008@redhat.com> <1284911040.9521.244.camel@frechmops.schnuffi.conrad.localdomain> <20100919155347.GA3008@redhat.com> <20100919160451.GA18012@morn.localdomain> <20100919161214.GB3008@redhat.com> <20100919220331.GB488@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Conrad Wood , kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714Ab0ITGuX (ORCPT ); Mon, 20 Sep 2010 02:50:23 -0400 Content-Disposition: inline In-Reply-To: <20100919220331.GB488@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, Sep 19, 2010 at 06:03:31PM -0400, Kevin O'Connor wrote: > On Sun, Sep 19, 2010 at 06:12:14PM +0200, Gleb Natapov wrote: > > On Sun, Sep 19, 2010 at 12:04:51PM -0400, Kevin O'Connor wrote: > > > I'm confused. The "cpu_set x offline" doesn't appear to do anything > > > for me. It does not disable the cpu, nor does it inform the guest to > > > disable the cpu. > [...] > > Then cpu eject method in seabios has a bug. When "cpu_set x offline" is > > called qemu sets status bit in gpe and injects ACPI interrupt. ACPI > > should do Notify() on cpu object when it happens. > > I was wrong. The "cpu_set x offline" does send an event to the guest > OS. SeaBIOS even forwards the event along - as far as I can tell a > Notify(CPxx, 3) event is generated by SeaBIOS. > > My Windows 7 ultimate beta seems to receive the event okay (it pops up > a dialog box which says you can't unplug cpus). > It may react to Eject() method. > Unfortunately, my test linux guest OS (FC13) doesn't seem to do > anything with the unplug Notify event. I've tried with the original > FC13 and with a fully updated version - no luck. > > So, I'm guessing this has something to do with the guest OS. > Can you verify that _STA() return zero after cpu unplug? -- Gleb.