From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56860 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OxcWZ-0007Un-4u
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:19:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OxcWX-0007iX-Gz
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:18:59 -0400
Received: from mail-fx0-f45.google.com ([209.85.161.45]:64451)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgar.iglesias@gmail.com>) id 1OxcWX-0007iI-AC
	for qemu-devel@nongnu.org; Mon, 20 Sep 2010 05:18:57 -0400
Received: by fxm13 with SMTP id 13so616193fxm.4
	for <qemu-devel@nongnu.org>; Mon, 20 Sep 2010 02:18:56 -0700 (PDT)
Date: Mon, 20 Sep 2010 11:03:37 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] e1000: Pad short frames to minimum size
	(60 bytes)
Message-ID: <20100920090337.GB618@edde.se.axis.com>
References: <1284842625-13920-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<20100918212710.GB3981@laped.lan>
	<AANLkTi=AM+o53WqPyjTycA+Xtqv+E1zRW2bUBAnc=Oqe@mail.gmail.com>
	<4C972060.7030002@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C972060.7030002@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@gmail.com>, 638955@bugs.launchpad.net, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>

On Mon, Sep 20, 2010 at 10:50:40AM +0200, Kevin Wolf wrote:
> Am 19.09.2010 08:36, schrieb Stefan Hajnoczi:
> > On Sat, Sep 18, 2010 at 10:27 PM, Edgar E. Iglesias
> > <edgar.iglesias@gmail.com> wrote:
> >> This doesn't look right. AFAIK, MAC's dont pad on receive.
> > 
> > I agree.  NICs that do padding will do it on transmit, not receive.
> > Anything coming in on the wire should already have the minimum length.
> > 
> > In QEMU that isn't true today and that's why rtl8139, pcnet, and
> > ne2000 already do this same padding.  This patch is the smallest
> > change to cover e1000.
> 
> What's the reason that it isn't true in QEMU today? Shouldn't we fix
> these problems rather than making device emulations incorrect to
> compensate for it?

Yes we should, I agree.

Cheers