From: Clemens Buchacher <drizzd@aon.at>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 3/3] use cache for function names in hunk headers
Date: Mon, 20 Sep 2010 19:36:05 +0200 [thread overview]
Message-ID: <20100920173605.GA13057@localhost> (raw)
In-Reply-To: <AANLkTikArADX8XviB99VtkkmKmVbs9jHPHw9PNSmiOc3@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Sun, Sep 19, 2010 at 10:24:52PM +0200, Sverre Rabbelier wrote:
>
> On Sun, Sep 19, 2010 at 11:59, Clemens Buchacher <drizzd@aon.at> wrote:
> > 2.78user 0.01system 0:02.82elapsed 99%CPU
> > 0.05user 0.01system 0:00.06elapsed 96%CPU
>
> Very nice. It would improve the commit message if you could explain
> what exactly it is this optimizes though, saving the reader from
> having to read through t3419 to find out.
Ok.
The test creates a file with 50000 lines and a one-line change
every 10 lines, i.e., about 5000 hunks. Since none of the lines
matches a function definition, previous to this optimization, the
file was searched 5000 times.
Clemens
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2010-09-20 17:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 9:59 Patch id tests and diff performance optimization Clemens Buchacher
2010-09-19 9:59 ` [PATCH 1/3] add rebase patch id tests Clemens Buchacher
2010-09-19 9:59 ` [PATCH 2/3] do not search functions for patch ID Clemens Buchacher
2010-09-19 9:59 ` [PATCH 3/3] use cache for function names in hunk headers Clemens Buchacher
2010-09-19 20:24 ` Sverre Rabbelier
2010-09-20 17:36 ` Clemens Buchacher [this message]
2010-09-20 19:15 ` Sverre Rabbelier
2010-09-23 7:04 ` [PATCH 3/3 v2] " Clemens Buchacher
2010-09-26 16:26 ` René Scharfe
2010-09-26 20:43 ` Clemens Buchacher
2010-09-26 22:17 ` René Scharfe
2010-09-27 17:52 ` Junio C Hamano
2010-09-30 18:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920173605.GA13057@localhost \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.