From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Tejun Heo <tj@kernel.org>,
Gregory Haskins <ghaskins@novell.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm: fix irqfd assign/deassign race
Date: Mon, 20 Sep 2010 15:35:47 -0300 [thread overview]
Message-ID: <20100920183547.GC27404@amt.cnet> (raw)
In-Reply-To: <20100919170231.GA12620@redhat.com>
On Sun, Sep 19, 2010 at 07:02:31PM +0200, Michael S. Tsirkin wrote:
> I think I see the following (theoretical) race:
>
> During irqfd assign, we drop irqfds lock before we
> schedule inject work. Therefore, deassign running
> on another CPU could cause shutdown and flush to run
> before inject, causing user after free in inject.
>
> A simple fix it to schedule inject under the lock.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
Applied, thanks.
next prev parent reply other threads:[~2010-09-20 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 17:02 [PATCH] kvm: fix irqfd assign/deassign race Michael S. Tsirkin
2010-09-19 20:02 ` Gregory Haskins
2010-09-19 20:02 ` Gregory Haskins
2010-09-20 18:35 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-19 17:02 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920183547.GC27404@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.