diff for duplicates of <20100921000747.GA15932@kroah.com> diff --git a/a/1.txt b/N1/1.txt index ba90f47..3357734 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -37,14 +37,14 @@ Why rename the variable if you don't have to? > /* Tell the MSD to open */ > - if (wlandev->open != NULL) { > - result = wlandev->open(wlandev); -> - if (result = 0) { +> - if (result == 0) { > - netif_start_queue(wlandev->netdev); > - wlandev->state = WLAN_DEVICE_OPEN; > - } > - } else { > - result = -EAGAIN; -> + if (wlandev->open = NULL) { -> + printk(KERN_ERR "Sorry, got wlandev->open = NULL.\n"); +> + if (wlandev->open == NULL) { +> + printk(KERN_ERR "Sorry, got wlandev->open == NULL.\n"); > + ret = -EAGAIN; > + goto end; diff --git a/a/content_digest b/N1/content_digest index 5f64c73..2d344d4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01284834652-26171-1-git-send-email-lkml@Think-Future.com\0" "From\0Greg KH <greg@kroah.com>\0" "Subject\0Re: [PATCH] Staging: wlan-ng: p80211netdev.c cleanup\0" - "Date\0Tue, 21 Sep 2010 00:07:47 +0000\0" + "Date\0Mon, 20 Sep 2010 17:07:47 -0700\0" "To\0Nils Radtke <lkml@think-future.com>\0" "Cc\0gregkh@suse.de" kernel-janitors@vger.kernel.org @@ -48,14 +48,14 @@ "> \t/* Tell the MSD to open */\n" "> -\tif (wlandev->open != NULL) {\n" "> -\t\tresult = wlandev->open(wlandev);\n" - "> -\t\tif (result = 0) {\n" + "> -\t\tif (result == 0) {\n" "> -\t\t\tnetif_start_queue(wlandev->netdev);\n" "> -\t\t\twlandev->state = WLAN_DEVICE_OPEN;\n" "> -\t\t}\n" "> -\t} else {\n" "> -\t\tresult = -EAGAIN;\n" - "> +\tif (wlandev->open = NULL) {\n" - "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open = NULL.\\n\");\n" + "> +\tif (wlandev->open == NULL) {\n" + "> +\t\tprintk(KERN_ERR \"Sorry, got wlandev->open == NULL.\\n\");\n" "> +\t\tret = -EAGAIN;\n" "> +\t\tgoto end;\n" "\n" @@ -82,4 +82,4 @@ "\n" greg k-h -f87a486baf1bb20c3299ab90a8bd7fbb6fa90994e73bbec63ffb8800e7512a20 +1cb2ff770d4394f0f85877053883759cb8c6e00fef6cdae2fdd906914511253f
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.