All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: zhangfei gao <zhangfei.gao@gmail.com>
Cc: linux-mmc@vger.kernel.org, Saeed Bishara <saeed@marvell.com>,
	Kyungmin Park <kmpark@infradead.org>,
	eric.y.miao@gmail.com, Haojian Zhuang <haojian.zhuang@gmail.com>
Subject: Re: [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller
Date: Tue, 21 Sep 2010 02:03:25 +0100	[thread overview]
Message-ID: <20100921010324.GA5873@void.printf.net> (raw)
In-Reply-To: <AANLkTi=jeL0J1kfT+toB3BEAGJ5Cc5jZsHstD1hutNQB@mail.gmail.com>

Hi Zhangfei/Saeed,

On Mon, Sep 20, 2010 at 05:46:02PM +0800, zhangfei gao wrote:
> Hi, Chris,
> 
> Here is patch to support pxa168(aspen)/pxa910(ttc)/mmp2, the
> controller follow sdh 3.0.
> Currently verified sd, Micron 16G emmc need some workaround, 8G is OK,
> marvell 8787 would be verified later.
> Help review.

Could you help me understand how this new driver relates to the Marvell
SoC driver that I merged last week (CONFIG_MMC_SDHCI_MV)?  Are the SD
IPs in Dove and MMP2 different enough to warrant a separate driver, or
could support for both be included in sdhci-mv.c?

If we're going to have multiple drivers for the SD blocks in Armada/PXA,
it at least seems that MMC_SDHCI_MV has been mis-named.  Any thoughts?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  parent reply	other threads:[~2010-09-21  1:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20  9:46 [PATCH] add support PXA168/PXA910/MMP2 SD Host Controller zhangfei gao
2010-09-20  9:50 ` Wolfram Sang
2010-09-20 12:09   ` zhangfei gao
2010-09-20 13:10     ` Wolfram Sang
2010-09-21  8:24       ` zhangfei gao
2010-09-21 10:11         ` Wolfram Sang
2010-09-21 10:18           ` Eric Miao
2010-09-21 16:18           ` Chris Ball
2010-09-21  1:03 ` Chris Ball [this message]
2010-09-21  3:16   ` zhangfei gao
2010-09-22  2:27     ` Chris Ball
2010-09-21  9:42 ` claud yu
2010-09-26  9:05   ` zhangfei gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100921010324.GA5873@void.printf.net \
    --to=cjb@laptop.org \
    --cc=eric.y.miao@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=kmpark@infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=saeed@marvell.com \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.