From: Tony Lindgren <tony@atomide.com>
To: Madhusudhan <madhu.cr@ti.com>
Cc: cjb@laptop.org, linux-mmc@vger.kernel.org,
linux-omap@vger.kernel.org, santosh.shilimkar@ti.com
Subject: Re: [PATCH] OMAP4: HSMMC cmd line reset change
Date: Tue, 21 Sep 2010 07:47:05 -0700 [thread overview]
Message-ID: <20100921144705.GP4611@atomide.com> (raw)
In-Reply-To: <738912BD0A0F48FC9E3159F923571E9E@am.dhcp.ti.com>
* Madhusudhan <madhu.cr@ti.com> [100920 09:06]:
> >
> > Please don't use cpu_is_omapxxxx tests in the drivers, drivers
> > should be generic.
> >
> > Instead, just pass a feature flag in the platform_data for this
> > feature like HSMMC_REVERSE_RESET_LOGIC or similar.
> >
>
> This is not a feature. It is like an ERRATA fix. I am yet to receive an
> errata number though. How about dealing with this like an errata fix similar
> to the way in arch/mach-omap2/serial.c done for the uart case?
Yes setting some HSMMC_ERRATA_XYZ flag works too.
> The mmc ip revision will not help because it really does not change to
> distinguish such issues.
OK. Then I guess your only option is to pass the errata flag in
the platform_data.
Regards,
Tony
next prev parent reply other threads:[~2010-09-21 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-15 23:58 [PATCH] OMAP4: HSMMC cmd line reset change Madhusudhan Chikkature
2010-09-16 21:27 ` Chris Ball
2010-09-17 15:48 ` Tony Lindgren
2010-09-20 16:14 ` Madhusudhan
2010-09-21 14:47 ` Tony Lindgren [this message]
2010-09-22 17:13 ` Madhusudhan
2010-09-22 17:25 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100921144705.GP4611@atomide.com \
--to=tony@atomide.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.