All of lore.kernel.org
 help / color / mirror / Atom feed
From: matt mooney <mfm@muteddisk.com>
To: Tim Gardner <tim.gardner@canonical.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
	Brett Rudley <brudley@broadcom.com>,
	Henry Ptasinski <henryp@broadcom.com>,
	Nohee Ko <noheek@broadcom.com>
Subject: Re: [PATCH] staging: brcm80211: Make CFLAGS explicit
Date: Tue, 21 Sep 2010 18:56:02 -0700	[thread overview]
Message-ID: <20100922015602.GB12118@haskell.muteddisk.com> (raw)
In-Reply-To: <1284736810-2940-1-git-send-email-tim.gardner@canonical.com>

On 09:20 Fri 17 Sep     , Tim Gardner wrote:
> -EXTRA_CFLAGS := -DBCMDBG -DWLC_HIGH -DSTA -DWME -DWL11N -DDBAND -DBCMDMA32 -DBCMNVRAMR -Idrivers/staging/brcm80211/sys -Idrivers/staging/brcm80211/phy -Idrivers/staging/brcm80211/util -Idrivers/staging/brcm80211/include -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes
> +EXTRA_CFLAGS := -DBCMDBG -DWME -DWL11N -DDBAND -DBCMDMA32 -DBCMNVRAMR -Idrivers/staging/brcm80211/sys -Idrivers/staging/brcm80211/phy -Idrivers/staging/brcm80211/util -Idrivers/staging/brcm80211/include -Wall -Wstrict-prototypes -Werror -Wmissing-prototypes

Also, since you are changing this file, you should use ccflags-y instead of the
deprecated EXTRA_CFLAGS.

Thanks,
mfm

      parent reply	other threads:[~2010-09-22  1:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-17 15:20 [PATCH] staging: brcm80211: Make CFLAGS explicit Tim Gardner
2010-09-17 16:21 ` Greg KH
2010-09-17 17:44   ` Tim Gardner
2010-09-17 17:58     ` Greg KH
2010-09-17 18:03     ` Brett Rudley
2010-09-17 18:33       ` Tim Gardner
2010-09-17 18:39         ` Brett Rudley
     [not found] ` <FD96C117992C584DBC47231B1EB6F5568206497F85@SJEXCHCCR02.corp.ad.broadcom.com>
2010-09-21  3:54   ` [PATCH] staging: brcm80211: add fullmac driver Greg KH
2010-09-22  1:56 ` matt mooney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100922015602.GB12118@haskell.muteddisk.com \
    --to=mfm@muteddisk.com \
    --cc=brudley@broadcom.com \
    --cc=gregkh@suse.de \
    --cc=henryp@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noheek@broadcom.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.