From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: regulator: max8998: BUCK1/2 control augmented by GPIO pins
Date: Wed, 22 Sep 2010 11:26:51 +0100 [thread overview]
Message-ID: <20100922102651.GA22361@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20100922084641.6be55f02@lmajewski.digital.local>
On Wed, Sep 22, 2010 at 08:46:41AM +0200, Lukasz Majewski wrote:
> Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> > For the voltage selection values I'm somewhat surprised to see them
> > specified in the platform data - I would instead expect to see them
> > figured out at runtime based on the voltages that are being set.
> I'd like to ask you for clarification on this statement. Correct me if
> I'm wrong, but I think that some default voltage values should be
> declared in platform data (according to the chip manual) to facilitate
> dynamic voltage scaling feature. I suspect that this information is
> platform specific and should be adjusted for each chip separately.
Assume that I've never seen the chip datasheet. What exactly is this
platform data configuring?
I would expect to see platform data configuring the default state of the
GPIOs at power up but that doesn't seem to be what's being configured
here. For anything configured via registers I would expect the driver
to read the state of the chip at startup.
next prev parent reply other threads:[~2010-09-22 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 14:18 [PATCH] mfd: regulator: max8998: BUCK1/2 control augmented by GPIO pins Lukasz Majewski
2010-09-21 15:01 ` Mark Brown
2010-09-22 6:46 ` Lukasz Majewski
2010-09-22 10:26 ` Mark Brown [this message]
2010-09-24 9:08 ` Lukasz Majewski
2010-09-24 9:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922102651.GA22361@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.