From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@redhat.com, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf build fixes for opensuse 10.0
Date: Wed, 22 Sep 2010 20:08:34 +0200 [thread overview]
Message-ID: <20100922180834.GA8482@elte.hu> (raw)
In-Reply-To: <20100922090336.GA5338@basil.fritz.box>
* Andi Kleen <andi@firstfloor.org> wrote:
> Fix the perf Makefile to compile on opensuse 10.0
>
> -Werror in shipping code is usually a bad idea. Remove that. Also
> remove warning options that are not supported in older compilers. And
> fix a missing include for __always_inline.
NAK, for obvious reasons.
Please send patches that fix those warnings instead. Yes, some will be
false positives - but quite a few will point to problems we want to
address.
Thanks,
Ingo
prev parent reply other threads:[~2010-09-22 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-22 9:03 [PATCH] perf build fixes for opensuse 10.0 Andi Kleen
2010-09-22 10:48 ` John Kacur
2010-09-22 11:15 ` Andi Kleen
2010-09-22 13:10 ` John Kacur
2010-09-22 13:25 ` Andi Kleen
2010-09-22 18:20 ` Ingo Molnar
2010-09-22 18:08 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100922180834.GA8482@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.