From: Tom Lyon <pugs@cisco.com>
To: Andy Walls <awalls@md.metrocast.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] VFIO V4: VFIO driver: Non-privileged user level PCI drivers
Date: Thu, 23 Sep 2010 12:33:52 -0700 [thread overview]
Message-ID: <201009231233.52541.pugs@cisco.com> (raw)
In-Reply-To: <1285246681.6715.11.camel@morgan.silverblock.net>
On Thursday, September 23, 2010 05:58:01 am Andy Walls wrote:
> Hi Tom,
>
> pci_iomap() can possibly return NULL here and also in
> vfio_mem_readwrite(). Even if there are no security implications
> (unintended access to low I/O ports?), I think you still have potential
> for an Oops in the code below.
>
> ... unless there's a reason why pci_iomap() can't possibly return NULL
> in these instances. Maybe I'm missing something.
>
> Regards,
> Andy
Thanks for the catch.
next prev parent reply other threads:[~2010-09-23 19:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 12:58 [PATCH 3/3] VFIO V4: VFIO driver: Non-privileged user level PCI drivers Andy Walls
2010-09-23 19:33 ` Tom Lyon [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-22 21:18 Tom Lyon
2010-09-22 21:18 ` Tom Lyon
2010-09-26 14:54 ` Michael S. Tsirkin
2010-09-30 21:43 ` Tom Lyon
2010-10-03 12:27 ` Michael S. Tsirkin
2010-09-27 11:54 ` Michael S. Tsirkin
2010-09-27 20:57 ` Alex Williamson
2010-09-28 10:14 ` Michael S. Tsirkin
2010-09-30 23:09 ` Tom Lyon
2010-10-03 13:02 ` Michael S. Tsirkin
2010-09-27 20:41 ` Alex Williamson
2010-10-15 22:29 ` Tom Lyon
2010-09-27 20:46 ` Alex Williamson
2010-09-28 10:09 ` Michael S. Tsirkin
2010-09-28 14:26 ` Alex Williamson
2010-09-28 14:40 ` Michael S. Tsirkin
2010-09-28 17:10 ` Alex Williamson
2010-09-28 17:36 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009231233.52541.pugs@cisco.com \
--to=pugs@cisco.com \
--cc=awalls@md.metrocast.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.