From: matt mooney <mfm@muteddisk.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: kernel-janitors@vger.kernel.org, Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Avi Kivity <avi@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 12/20] powerpc: change to new flag variables
Date: Thu, 23 Sep 2010 17:49:18 +0000 [thread overview]
Message-ID: <20100923174918.GA3035@haskell.muteddisk.com> (raw)
In-Reply-To: <20100923201923.366779a1.sfr@canb.auug.org.au>
On 20:19 Thu 23 Sep , Stephen Rothwell wrote:
> Hi Matt,
>
> On Wed, 22 Sep 2010 23:51:09 -0700 matt mooney <mfm@muteddisk.com> wrote:
> >
> > Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
>
> This looks good. One comment below ...
>
> > --- a/arch/powerpc/platforms/pseries/Makefile
> > +++ b/arch/powerpc/platforms/pseries/Makefile
> > @@ -1,10 +1,5 @@
> > -ifeq ($(CONFIG_PPC64),y)
> > -EXTRA_CFLAGS += -mno-minimal-toc
> > -endif
> > -
> > -ifeq ($(CONFIG_PPC_PSERIES_DEBUG),y)
> > -EXTRA_CFLAGS += -DDEBUG
> > -endif
> > +ccflags-$(CONFIG_PPC64) := -mno-minimal-toc
> > +ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG
> >
> > obj-y := lpar.o hvCall.o nvram.o reconfig.o \
> > setup.o iommu.o event_sources.o ras.o \
> > @@ -23,7 +18,7 @@ obj-$(CONFIG_MEMORY_HOTPLUG) += hotplug-memory.o
> > obj-$(CONFIG_HVC_CONSOLE) += hvconsole.o
> > obj-$(CONFIG_HVCS) += hvcserver.o
> > obj-$(CONFIG_HCALL_STATS) += hvCall_inst.o
> > -obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > +obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > obj-$(CONFIG_CMM) += cmm.o
> > obj-$(CONFIG_DTL) += dtl.o
>
> This looks like a spurious extra hunk.
Hi Stephen,
Yeah your right, logically it doesn't follow from my changeset. I should
have left it alone, but it was the only line in the file that didn't align
properly with its surrounding area.
-mfm
WARNING: multiple messages have this Message-ID (diff)
From: matt mooney <mfm@muteddisk.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: kernel-janitors@vger.kernel.org, Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Avi Kivity <avi@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 12/20] powerpc: change to new flag variables
Date: Thu, 23 Sep 2010 10:49:18 -0700 [thread overview]
Message-ID: <20100923174918.GA3035@haskell.muteddisk.com> (raw)
In-Reply-To: <20100923201923.366779a1.sfr@canb.auug.org.au>
On 20:19 Thu 23 Sep , Stephen Rothwell wrote:
> Hi Matt,
>
> On Wed, 22 Sep 2010 23:51:09 -0700 matt mooney <mfm@muteddisk.com> wrote:
> >
> > Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
>
> This looks good. One comment below ...
>
> > --- a/arch/powerpc/platforms/pseries/Makefile
> > +++ b/arch/powerpc/platforms/pseries/Makefile
> > @@ -1,10 +1,5 @@
> > -ifeq ($(CONFIG_PPC64),y)
> > -EXTRA_CFLAGS += -mno-minimal-toc
> > -endif
> > -
> > -ifeq ($(CONFIG_PPC_PSERIES_DEBUG),y)
> > -EXTRA_CFLAGS += -DDEBUG
> > -endif
> > +ccflags-$(CONFIG_PPC64) := -mno-minimal-toc
> > +ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG
> >
> > obj-y := lpar.o hvCall.o nvram.o reconfig.o \
> > setup.o iommu.o event_sources.o ras.o \
> > @@ -23,7 +18,7 @@ obj-$(CONFIG_MEMORY_HOTPLUG) += hotplug-memory.o
> > obj-$(CONFIG_HVC_CONSOLE) += hvconsole.o
> > obj-$(CONFIG_HVCS) += hvcserver.o
> > obj-$(CONFIG_HCALL_STATS) += hvCall_inst.o
> > -obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > +obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > obj-$(CONFIG_CMM) += cmm.o
> > obj-$(CONFIG_DTL) += dtl.o
>
> This looks like a spurious extra hunk.
Hi Stephen,
Yeah your right, logically it doesn't follow from my changeset. I should
have left it alone, but it was the only line in the file that didn't align
properly with its surrounding area.
-mfm
WARNING: multiple messages have this Message-ID (diff)
From: matt mooney <mfm@muteddisk.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kernel-janitors@vger.kernel.org, Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Avi Kivity <avi@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 12/20] powerpc: change to new flag variables
Date: Thu, 23 Sep 2010 10:49:18 -0700 [thread overview]
Message-ID: <20100923174918.GA3035@haskell.muteddisk.com> (raw)
In-Reply-To: <20100923201923.366779a1.sfr@canb.auug.org.au>
On 20:19 Thu 23 Sep , Stephen Rothwell wrote:
> Hi Matt,
>
> On Wed, 22 Sep 2010 23:51:09 -0700 matt mooney <mfm@muteddisk.com> wrote:
> >
> > Replace EXTRA_CFLAGS with ccflags-y and EXTRA_AFLAGS with asflags-y.
>
> This looks good. One comment below ...
>
> > --- a/arch/powerpc/platforms/pseries/Makefile
> > +++ b/arch/powerpc/platforms/pseries/Makefile
> > @@ -1,10 +1,5 @@
> > -ifeq ($(CONFIG_PPC64),y)
> > -EXTRA_CFLAGS += -mno-minimal-toc
> > -endif
> > -
> > -ifeq ($(CONFIG_PPC_PSERIES_DEBUG),y)
> > -EXTRA_CFLAGS += -DDEBUG
> > -endif
> > +ccflags-$(CONFIG_PPC64) := -mno-minimal-toc
> > +ccflags-$(CONFIG_PPC_PSERIES_DEBUG) += -DDEBUG
> >
> > obj-y := lpar.o hvCall.o nvram.o reconfig.o \
> > setup.o iommu.o event_sources.o ras.o \
> > @@ -23,7 +18,7 @@ obj-$(CONFIG_MEMORY_HOTPLUG) += hotplug-memory.o
> > obj-$(CONFIG_HVC_CONSOLE) += hvconsole.o
> > obj-$(CONFIG_HVCS) += hvcserver.o
> > obj-$(CONFIG_HCALL_STATS) += hvCall_inst.o
> > -obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > +obj-$(CONFIG_PHYP_DUMP) += phyp_dump.o
> > obj-$(CONFIG_CMM) += cmm.o
> > obj-$(CONFIG_DTL) += dtl.o
>
> This looks like a spurious extra hunk.
Hi Stephen,
Yeah your right, logically it doesn't follow from my changeset. I should
have left it alone, but it was the only line in the file that didn't align
properly with its surrounding area.
-mfm
next prev parent reply other threads:[~2010-09-23 17:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-23 6:51 [PATCH 12/20] powerpc: change to new flag variables matt mooney
2010-09-23 6:51 ` matt mooney
2010-09-23 6:51 ` matt mooney
2010-09-23 10:19 ` Stephen Rothwell
2010-09-23 10:19 ` Stephen Rothwell
2010-09-23 10:19 ` Stephen Rothwell
2010-09-23 17:49 ` matt mooney [this message]
2010-09-23 17:49 ` matt mooney
2010-09-23 17:49 ` matt mooney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100923174918.GA3035@haskell.muteddisk.com \
--to=mfm@muteddisk.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.