From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: libxl: xl create  segfaults
Date: Thu, 23 Sep 2010 18:18:05 +0200
Message-ID: <201009231818.06970.Christoph.Egger@amd.com>
References: <201009231227.29730.Christoph.Egger@amd.com>
	<1285257340.432.7.camel@qabil.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1285257340.432.7.camel@qabil.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Gianni Tedesco <gianni.tedesco@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Thursday 23 September 2010 17:55:39 Gianni Tedesco wrote:
> On Thu, 2010-09-23 at 11:27 +0100, Christoph Egger wrote:
> > Hi!
> >
> > 'xl create' crashes due to stack corruption.
>
> ---8<-------------------------------------------
>
> xl: Fix stack corruption caused by non-terminated call to libxl__xs_writev

Confirmed. This fixes the crash. 'xl create' now hangs in a loop. I will have 
a look at this later.

>
> Signed-off-by: Gianni Tedesco <gianni.tedesco@citrix.com>
>
> diff -r 50c1cc209f8f tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Wed Sep 22 18:29:24 2010 +0100
> +++ b/tools/libxl/libxl.c	Thu Sep 23 16:54:09 2010 +0100
> @@ -1718,7 +1718,7 @@ retry_transaction:
>          vm_path = libxl__xs_read(&gc,t,libxl__sprintf(&gc, "%s/vm",
> p->dom_path)); if (vm_path) {
>              /* Now write the vncpassword into it. */
> -            pass_stuff = libxl__calloc(&gc, 2, sizeof(char *));
> +            pass_stuff = libxl__calloc(&gc, 3, sizeof(char *));
>              pass_stuff[0] = "vncpasswd";
>              pass_stuff[1] = info->vncpasswd;
>              libxl__xs_writev(&gc,t,vm_path,pass_stuff);



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632